test: migrate tests to testing-library #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Wxh16144
changed the title
|
Ready~, review at any time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 98.66% 98.69% +0.02%
==========================================
Files 3 3
Lines 300 306 +6
Branches 133 136 +3
==========================================
+ Hits 296 302 +6
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
这里 ae34163 可能需要确认一下？ |
|
没问题，不需要额外的 types 配置了。 |
|
测试文件也重构成 ts ？ |
zombieJ
reviewed
Nov 29, 2023
zombieJ
approved these changes
Nov 29, 2023
Wxh16144
added a commit
to Wxh16144-forks/pagination
that referenced
this pull request
Dec 1, 2023
afc163
pushed a commit
that referenced
this pull request
Dec 1, 2023
* chore: update eslint fix compile error * fix: fix export TS description ref: #539 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: #514 (comment)