Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extends showSizeChanger prop #533

Closed
wants to merge 0 commits into from

Conversation

jacklee814
Copy link

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ❌ Failed (Inspect) Nov 29, 2023 4:39am

@jacklee814
Copy link
Author

@afc163 這樣如何呢?

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ac879ed) 93.31% compared to head (0a3a337) 93.12%.
Report is 9 commits behind head on master.

❗ Current head 0a3a337 differs from pull request most recent head 53aee8e. Consider uploading reports for the commit 53aee8e to get more accurate results

Files Patch % Lines
src/Pagination.tsx 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
- Coverage   93.31%   93.12%   -0.20%     
==========================================
  Files           5        5              
  Lines         374      378       +4     
  Branches      140      146       +6     
==========================================
+ Hits          349      352       +3     
- Misses         24       25       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wxh16144
Copy link
Contributor

这应该需要补充一份测试用例?

@afc163
Copy link
Member

afc163 commented Nov 28, 2023

覆盖率掉了

@jacklee814
Copy link
Author

我來補上測試

@jacklee814
Copy link
Author

我等這個 merge 吧
#539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants