Render data- and aria- props #227
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 93.38% 93.39% +<.01%
==========================================
Files 17 17
Lines 726 727 +1
Branches 208 209 +1
==========================================
+ Hits 678 679 +1
Misses 40 40
Partials 8 8
Continue to review full report at Codecov.
|
Nice |
Can this be merged? Is there anything that I need to adjust? |
This would be really helpful in my application. Can this please be merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR is the same as #211, but address the comments of @yesmeck.
@matthewlein was contractor for us and is no longer on the project and will more than likely not update the other PR.