Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render data- and aria- props #227

Merged
merged 1 commit into from Oct 15, 2018
Merged

Render data- and aria- props #227

merged 1 commit into from Oct 15, 2018

Conversation

@kagd
Copy link
Contributor

@kagd kagd commented Aug 6, 2018

This PR is the same as #211, but address the comments of @yesmeck.

@matthewlein was contractor for us and is no longer on the project and will more than likely not update the other PR.

Grant Klinsing
@codecov-io
Copy link

@codecov-io codecov-io commented Aug 6, 2018

Codecov Report

Merging #227 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   93.38%   93.39%   +<.01%     
==========================================
  Files          17       17              
  Lines         726      727       +1     
  Branches      208      209       +1     
==========================================
+ Hits          678      679       +1     
  Misses         40       40              
  Partials        8        8
Impacted Files Coverage Δ
src/Table.js 86.47% <100%> (+0.08%) ⬆️
src/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93e8c4...c9fa422. Read the comment docs.

@matthewlein
Copy link

@matthewlein matthewlein commented Aug 18, 2018

Nice 👍

@kagd
Copy link
Contributor Author

@kagd kagd commented Aug 29, 2018

Can this be merged? Is there anything that I need to adjust?

@meastes
Copy link

@meastes meastes commented Oct 3, 2018

This would be really helpful in my application. Can this please be merged soon?

@yesmeck yesmeck merged commit fe68e44 into react-component:master Oct 15, 2018
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 93.38%)
Details
codecov/project 93.39% (+<.01%) compared to c93e8c4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants