Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessing PropTypes via the main React package is deprecated. #49

Open
gnunua opened this issue Jul 31, 2017 · 2 comments
Open

Accessing PropTypes via the main React package is deprecated. #49

gnunua opened this issue Jul 31, 2017 · 2 comments

Comments

@gnunua
Copy link

gnunua commented Jul 31, 2017 •
edited
Loading

lowPriorityWarning.js:40 Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs

in LineChart.js still using React.propTypes instead of exporting PropTypes from prop-types
@jeroenptrs
Copy link

jeroenptrs commented Oct 18, 2017 •
edited
Loading

proptypes has been taken out of react's core completely. It needs to be imported via 'prop-types' package. React Docs

@jeroenptrs
Copy link

jeroenptrs commented Oct 18, 2017 •
edited
Loading

I opened a PR, but it seems the problem is all over the react-D3 ecosystem.

@deanrad deanrad mentioned this issue Dec 4, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnunua @jeroenptrs