fix: do not cancel touch events if they are non-cancelable #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents errors like this in Chrome mobile: ``` IgnoredEventCancel: Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted. ```
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 87 87
Lines 2505 2505
Branches 467 469 +2
=======================================
Hits 1245 1245
Misses 1260 1260
|
turn off patch coverage checks
darthtrevino
added a commit
that referenced
this pull request
Feb 3, 2022
* fix: do not cancel touch events if they are non-cancelable This prevents errors like this in Chrome mobile: ``` IgnoredEventCancel: Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted. ``` * build: update auto-merge to check actor * build: add node 14 to build matrix * build: add codecov.yml to tune codecov settings turn off patch coverage checks Co-authored-by: Chris Trevino <chtrevin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents errors like this in Chrome mobile:
I am getting quite a few reports for these errors from end-users (using ReportingObserver). As calling
preventDefault()is a no-op on a non-cancelable event, this change should not have any impact except removing those warnings.