fix bugs that occur in the presence of Array polyfills #10328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluebill1049
approved these changes
Apr 24, 2023
fkoulen
added a commit
to ASVGay/the-rhapsodies
that referenced
this pull request
Jun 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-hook-form](https://www.react-hook-form.com) ([source](https://togithub.com/react-hook-form/react-hook-form)) | [`7.43.9` -> `7.44.3`](https://renovatebot.com/diffs/npm/react-hook-form/7.43.9/7.44.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-hook-form/react-hook-form</summary> ### [`v7.44.3`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.44.3): Version 7.44.3 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.44.2...v7.44.3) 🦉 fix: add named component export ([#​10486](https://togithub.com/react-hook-form/react-hook-form/issues/10486)) 💭 fix React import inconsistency ([#​10479](https://togithub.com/react-hook-form/react-hook-form/issues/10479)) 🏙️ fix: removed code from the README updater which was trying to read a non-existent `docs/Helpers.yaml` 📝 fix doc: update urls from /api to /docs ([#​10468](https://togithub.com/react-hook-form/react-hook-form/issues/10468)) thanks to [@​Moshyfawn](https://togithub.com/Moshyfawn) @​[@​protofarer](https://togithub.com/protofarer) [@​farfromrest](https://togithub.com/farfromrest) ### [`v7.44.2`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.44.2): Version 7.44.2 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.44.1...v7.44.2) 🪟 fix [#​10456](https://togithub.com/react-hook-form/react-hook-form/issues/10456) `object.hasown` replaced with `hasOwnProperty` ([#​10458](https://togithub.com/react-hook-form/react-hook-form/issues/10458)) ### [`v7.44.1`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.44.1): Version 7.44.1 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.44.0...v7.44.1) 🐞 fix `<Form />` component content-type json type missing ([#​10454](https://togithub.com/react-hook-form/react-hook-form/issues/10454)) ### [`v7.44.0`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.44.0): Version 7.44.0 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.43.9...v7.44.0) 📄 New `<Form />` Component ([react-hook-form/react-hook-form#9735) https://react-hook-form.com/docs/useform/form - add try and catch for JSON.stringify ```tsx // Send post request with formData <Form action="/api" control={control} onSuccess={() => { alert("Great"); }} /> // Send post request with json form data <Form action="/api" encType="application/json" headers={{ accessToken: 'test' }}> {errors.root?.server.type === 500 && 'Error message'} {errors.root?.server.type === 400 && 'Error message'} </Form> // Send post request with formData with fetch <Form onSubmit={async ({ formData, data, formDataJson, event }) => { await fetch("api", { method: "post", body: formData, }); }} /> ``` 🗝️ support TransformedValues with useFormContext ([react-hook-form/react-hook-form#10322) ```tsx useFormContext<FormValue, TransformedValues>() ``` 🚔 added TTransformedValues to FormProvider ([react-hook-form/react-hook-form#10368) ```tsx FormProviderProps<TFieldValues, TContext, TTransformedValues> ``` 🐞 fix [react-hook-form/react-hook-form#10139 with errors diff from the previous with field array action ([react-hook-form/react-hook-form#10216) 🐞 related [react-hook-form/react-hook-form#10238 return default values in watch and useWatch when reset is called with an empty object 🦮 remove unnecessary as unknown as cast ([react-hook-form/react-hook-form#10300) 🧛♂️ close [react-hook-form/react-hook-form#10277 remove pattern empty string check ([react-hook-form/react-hook-form#10279) 🐞 fix [react-hook-form/react-hook-form#9037 bugs that occur in the presence of Array polyfills ([react-hook-form/react-hook-form#10328) 🫥 close [react-hook-form/react-hook-form#10348 stop shouldUseNativeValidation pass down constraint props ([react-hook-form/react-hook-form#10350) 😵💫 close [react-hook-form/react-hook-form#10386 re-register controller input to fix strict mode ([react-hook-form/react-hook-form#10418) ✍️ update form.tsx for TSdoc ([react-hook-form/react-hook-form#10399) thanks to [@​yasamoka](https://togithub.com/yasamoka) & [@​Torvin](https://togithub.com/Torvin) [@​ryota-murakami](https://togithub.com/ryota-murakami) & [@​devakrishna33](https://togithub.com/devakrishna33) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ASVGay/the-rhapsodies). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTUuMiIsInVwZGF0ZWRJblZlciI6IjM1LjExNS4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=-->
patrykkopycinski
added a commit
to elastic/kibana
that referenced
this pull request
Jul 12, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-hook-form](https://www.react-hook-form.com) ([source](https://togithub.com/react-hook-form/react-hook-form)) | [`^7.43.2` -> `^7.44.2`](https://renovatebot.com/diffs/npm/react-hook-form/7.43.2/7.44.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-hook-form/react-hook-form</summary> ### [`v7.44.2`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.44.2): Version 7.44.2 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.44.1...v7.44.2) 🪟 fix [#​10456](https://togithub.com/react-hook-form/react-hook-form/issues/10456) `object.hasown` replaced with `hasOwnProperty` ([#​10458](https://togithub.com/react-hook-form/react-hook-form/issues/10458)) ### [`v7.44.1`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.44.1): Version 7.44.1 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.44.0...v7.44.1) 🐞 fix `<Form />` component content-type json type missing ([#​10454](https://togithub.com/react-hook-form/react-hook-form/issues/10454)) ### [`v7.44.0`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.44.0): Version 7.44.0 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.43.9...v7.44.0) 📄 New `<Form />` Component ([react-hook-form/react-hook-form#9735) https://react-hook-form.com/docs/useform/form - add try and catch for JSON.stringify ```tsx // Send post request with formData <Form action="/api" control={control} onSuccess={() => { alert("Great"); }} /> // Send post request with json form data <Form action="/api" encType="application/json" headers={{ accessToken: 'test' }}> {errors.root?.server.type === 500 && 'Error message'} {errors.root?.server.type === 400 && 'Error message'} </Form> // Send post request with formData with fetch <Form onSubmit={async ({ formData, data, formDataJson, event }) => { await fetch("api", { method: "post", body: formData, }); }} /> ``` 🗝️ support TransformedValues with useFormContext ([react-hook-form/react-hook-form#10322) ```tsx useFormContext<FormValue, TransformedValues>() ``` 🚔 added TTransformedValues to FormProvider ([react-hook-form/react-hook-form#10368) ```tsx FormProviderProps<TFieldValues, TContext, TTransformedValues> ``` 🐞 fix [react-hook-form/react-hook-form#10139 with errors diff from the previous with field array action ([react-hook-form/react-hook-form#10216) 🐞 related [react-hook-form/react-hook-form#10238 return default values in watch and useWatch when reset is called with an empty object 🦮 remove unnecessary as unknown as cast ([react-hook-form/react-hook-form#10300) 🧛♂️ close [react-hook-form/react-hook-form#10277 remove pattern empty string check ([react-hook-form/react-hook-form#10279) 🐞 fix [react-hook-form/react-hook-form#9037 bugs that occur in the presence of Array polyfills ([react-hook-form/react-hook-form#10328) 🫥 close [react-hook-form/react-hook-form#10348 stop shouldUseNativeValidation pass down constraint props ([react-hook-form/react-hook-form#10350) 😵💫 close [react-hook-form/react-hook-form#10386 re-register controller input to fix strict mode ([react-hook-form/react-hook-form#10418) ✍️ update form.tsx for TSdoc ([react-hook-form/react-hook-form#10399) thanks to [@​yasamoka](https://togithub.com/yasamoka) & [@​Torvin](https://togithub.com/Torvin) [@​ryota-murakami](https://togithub.com/ryota-murakami) & [@​devakrishna33](https://togithub.com/devakrishna33) ### [`v7.43.9`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.43.9): Version 7.43.9 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.43.8...v7.43.9) 🍄 close [#​10195](https://togithub.com/react-hook-form/react-hook-form/issues/10195) close async defaultValues not load ([#​10203](https://togithub.com/react-hook-form/react-hook-form/issues/10203)) Revert "🐞 fix [#​10139](https://togithub.com/react-hook-form/react-hook-form/issues/10139) useFieldArray array error not updating in some cases ([#​10150](https://togithub.com/react-hook-form/react-hook-form/issues/10150))" ### [`v7.43.8`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.43.8): Version 7.43.8 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.43.7...v7.43.8) 🪡 related [#​10143](https://togithub.com/react-hook-form/react-hook-form/issues/10143) did not update dirty until interacted ([#​10157](https://togithub.com/react-hook-form/react-hook-form/issues/10157)) 🐞 fix [#​10139](https://togithub.com/react-hook-form/react-hook-form/issues/10139) useFieldArray array error not updating in some cases ([#​10150](https://togithub.com/react-hook-form/react-hook-form/issues/10150)) thanks to [@​kylemclean](https://togithub.com/kylemclean) ### [`v7.43.7`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.43.7): Version 7.43.7 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.43.6...v7.43.7) 🐞 fix [#​10131](https://togithub.com/react-hook-form/react-hook-form/issues/10131) regression on NaN data type ([#​10132](https://togithub.com/react-hook-form/react-hook-form/issues/10132)) 🐞 fix [#​10129](https://togithub.com/react-hook-form/react-hook-form/issues/10129) useFieldArray unmount fieldArray wihtout register ([#​10130](https://togithub.com/react-hook-form/react-hook-form/issues/10130)) 🦶 upgrade to TS 5.0.0 ([#​9834](https://togithub.com/react-hook-form/react-hook-form/issues/9834)) ### [`v7.43.6`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.43.6): Version 7.43.6 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.43.5...v7.43.6) 🐞 fix(appendErrors): incorrect type, it can take an array of errors ([#​10125](https://togithub.com/react-hook-form/react-hook-form/issues/10125)) ✍️ close [#​10096](https://togithub.com/react-hook-form/react-hook-form/issues/10096) react strict mode with mounted field value ([#​10102](https://togithub.com/react-hook-form/react-hook-form/issues/10102)) 🦮 fix: isLoading form state ([#​10095](https://togithub.com/react-hook-form/react-hook-form/issues/10095)) 📝 fix: typos in tsdoc ([#​10088](https://togithub.com/react-hook-form/react-hook-form/issues/10088)) 🩴 close [#​10078](https://togithub.com/react-hook-form/react-hook-form/issues/10078) prevent stabled aysnc validation ([#​10082](https://togithub.com/react-hook-form/react-hook-form/issues/10082)) 🐞 fix [#​10064](https://togithub.com/react-hook-form/react-hook-form/issues/10064) native validation when subscribe to isValid ([#​10072](https://togithub.com/react-hook-form/react-hook-form/issues/10072)) 📝 correct typo in field array type declaration ([#​10066](https://togithub.com/react-hook-form/react-hook-form/issues/10066)) thanks to [@​jorisre](https://togithub.com/jorisre) [@​chrisbarless](https://togithub.com/chrisbarless) [@​mjw-isp](https://togithub.com/mjw-isp) and [@​adamtowle](https://togithub.com/adamtowle) ### [`v7.43.5`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.43.5): Version 7.43.5 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.43.4...v7.43.5) 🐰 prevent runtime error with subscribe function ([#​10052](https://togithub.com/react-hook-form/react-hook-form/issues/10052)) 🪔 close [#​10045](https://togithub.com/react-hook-form/react-hook-form/issues/10045) improve `useController` defaultValue restore under strict mode with double `useEffect` ([#​10049](https://togithub.com/react-hook-form/react-hook-form/issues/10049)) 📷 improve form values state update ([#​10029](https://togithub.com/react-hook-form/react-hook-form/issues/10029)) ### [`v7.43.4`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.43.4): Version 7.43.4 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.43.3...v7.43.4) 🐞 fix [#​10021](https://togithub.com/react-hook-form/react-hook-form/issues/10021) issue with `.next` runtime error and fix cypress action ([#​10026](https://togithub.com/react-hook-form/react-hook-form/issues/10026)) ### [`v7.43.3`](https://togithub.com/react-hook-form/react-hook-form/releases/tag/v7.43.3): Version 7.43.3 [Compare Source](https://togithub.com/react-hook-form/react-hook-form/compare/v7.43.2...v7.43.3) 📐 fix `resetField` defaultValue type and reduce any type ([#​10024](https://togithub.com/react-hook-form/react-hook-form/issues/10024)) 🐞 fix [#​9997](https://togithub.com/react-hook-form/react-hook-form/issues/9997) issue on the mounted state is updated with values prop ([#​10001](https://togithub.com/react-hook-form/react-hook-form/issues/10001)) Revert "🏍 delete dirty fields node instead of marking as false ([#​9156](https://togithub.com/react-hook-form/react-hook-form/issues/9156))" ([#​9996](https://togithub.com/react-hook-form/react-hook-form/issues/9996)) 💅 improve state subscription consistency ([#​9984](https://togithub.com/react-hook-form/react-hook-form/issues/9984)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/elastic/kibana). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTkuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9037
Currently if
Array.prototypeis patched (for polyfilling reasons, for example), it completely breaksreact-hook-form. This is very inconvenient and something the consumer doesn't necessarily has control over (the patching might be done by a third-party script embedded outside of the consumer app).The underlying reason is that current version of the code doesn't use the recommended
Object.hasOwnchecks insidefor..inloops, hence iterating over properties added to the prototype and breaking the rest of the library code. This PR adds some tests to enforce the correct behaviour and fixes the underlying issue.