fix: Make paths in the CmakeLists scripts Windows friendly #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
reviewed
Nov 2, 2022
| ? path.join(sourceDir, userConfig.cmakeListsPath) | ||
| : path.join(sourceDir, 'build/generated/source/codegen/jni/CMakeLists.txt'); | ||
|
|
||
| if(process.platform == "win32") { | ||
| cmakeListsPath = cmakeListsPath.replaceAll("\\", "/") |
There was a problem hiding this comment.
can you do the same for androidMkPath as well?
There was a problem hiding this comment.
Hi .. Sorry, i missed tracking this PR. The fix may not be required form ndk-build as it can handle the windows file paths i believe .. I will check it out and raise another PR if required.
tido64
reviewed
Nov 2, 2022
thymikee
reviewed
Nov 2, 2022
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
thymikee
changed the title
thymikee
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Thank you! I'm not sure whether this change is safe for Android.mk as well. Let's put it into a separate PR, ideally by someone who has a Windows machine to test on, ok @cortinico?
thymikee
added a commit
that referenced
this pull request
Nov 4, 2022
* Fixing the paths to be windows friendly * Update packages/cli-platform-android/src/config/index.ts Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com> * Update packages/cli-platform-android/src/config/index.ts * fix: lint Co-authored-by: Michał Pierzchała <thymikee@gmail.com> Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
|
The fix may not be required form ndk-build as it can handle the windows file paths i believe .. I will check it out and raise another PR if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The paths in the CMake script generated for autolinking the modules contains backslashes which CMake don't like. This patch fixes the file paths to replace the backslashes with forward slases.
Test Plan:
Tested autolinking modules locally on windows.