imp: Migrate platform-ios to TypeScript
#620
Conversation
Esemesek
changed the title
platform-ios to TypesScriptplatform-ios to TypeScript
| @@ -18,18 +16,21 @@ describe('pods::isInstalled', () => { | |||
| it('returns false if pod is missing', () => { | |||
| const project = {podfile: path.join(PODFILES_PATH, 'PodfileSimple')}; | |||
| const podspecName = {podspecPath: '/path/NotExisting'}; | |||
| // @ts-ignore FIXME: Improve types | |||
There was a problem hiding this comment.
What was the issue with these?
There was a problem hiding this comment.
The isInstalled function is not written correctly. We are passing whole big objects to the function, but not all properties are used. I've added ts-ignore in the test to prevent adding unused mock data.
| export default function removeFromStaticLibraries( | ||
| project: any, | ||
| path: string, | ||
| opts: {[key: string]: any}, |
There was a problem hiding this comment.
Will you do a follow up PR to fix all instance of any? There's an awful lot of them…
There was a problem hiding this comment.
This is the plan. We have so many instances of any because library that we rely on - https://www.npmjs.com/package/xcode - has no typings. I want to write them in the future and make this module better. For now, this PR is big enough and didn't want to include the next big thing.
|
@tido64 I resolved all the comments that were fixed. There is still plenty of work to do. We have to add types to the |
thymikee
force-pushed
the
ios-typescript
branch
from
f01b7b3
to
63fb47c
Compare
Summary:
This PR includes moving the whole
platform-iosmodule to Typescript. There were a lot of issues while moving this module because most of it was untyped and the main library that we rely on (xcode) is untyped. Also, there is a lot of explicit casting toanytype, empty stub definitions forxcodemodule and plenty of@ts-ignore.Changes:
.jsto.tsplatform-ioscli-typesTODO:
- [ ] - Fix as many types issues as possible- [ ] - Improve typings forxcode^ Since those will take much more effort and time to make, I think we can make issues for them after we merge this PR.
Test Plan:
👍- All the check are passing.