Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The React Native Community guidelines #106

Closed
wants to merge 1 commit into from
Closed

Conversation

kelset
Copy link
Member

@kelset kelset commented Mar 5, 2019

I'll be honest - creating this document was always in my mind since the start of this repository.

We are at a phase where we need to reinforce the foundation of what we do and how we do it, following all the new code influx from the Lean Core effort.

Once this PR is approved, here's a rough plan I was thinking about:

  • renaming this repo to meta and doing some house chores to reflect it (etc, rewording the READMEs, etc)
  • created a gSheet file with all the maintainers, which repo they are working on and how to reach out to them in order to keep an eye on how things are moving
  • adding a guidelines folder with all the different guidelines for the community (there are currently 3 being drafted: Repository Maintenance, Project Setup, Community Management)
  • enforce the new guidelines; this should be mostly easy thanks to direct communication and the fact that GitHub allows for organization-wide community health files

If you have any feedback, anything that you feel it's missing, please write a comment here so that the conversation can continue.


Acknowledgements

Thanks to @grabbou @Salakar and @Titozzz for early feedback.

This document is inspired by, among other files, the ocaml community manifesto.

@pvinis
Copy link
Member

pvinis commented Mar 5, 2019

I like the text and the ideas for next steps. My main concern would be to make sure we have this gsheet and ways to contact people that maintain and develop the repos of this org, but moreover I think it would be very cool if more than just one person is able and enabled to help in case the current maintainer is unable to continue for example. I would be very sad if say in a year, some library here is stale and outdated. Maybe part of the guidelines should be to have "regular" checks of the live-ness of the repos here, and prevent any problems with that by having the rest of the community help with that. Does that make sense?

@xzilja
Copy link
Member

xzilja commented Mar 5, 2019

Definitely a good idea, it would be good to have consistent project structures / readmes across the packages and additional things like podspec files for ios installations.

@Eyesonly88
Copy link

Thanks for starting this discussion.
Another idea is to have a way to elect primary and secondary maintainers (or more). So we can share the load and participate as necessary. For example, someone could be available to help with docs/reviews in November / December etc...

@cpojer
Copy link
Member

cpojer commented Mar 5, 2019

Thanks for kicking this off! @hramos and I have also started a similar write up from within FB but it's still in the draft stage. I'll be off for a week but will work on putting it together and sharing it more widely soon.

@kelset
Copy link
Member Author

kelset commented Mar 5, 2019

@cpojer I was aware of FB doing some work around the contribution guidelines, but nothing strictly connected to this. If it's more connected it may be worth a catchup privately.

re: maintainers (cc @pvinis @Eyesonly88)
I absolutely share your concerns, in my current guideline draft (I've added the titles in the first post) for maintainers, ideally there would always be at least 2, best 3 per each. We can discuss the details once there is a PR for the guidelines for that 🤗

@kelset kelset added the 💡 Proposal This label identifies a proposal label Mar 5, 2019
@grabbou
Copy link
Member

grabbou commented Mar 5, 2019

@cpojer we also started working with @kelset on guidelines for maintainers (which is something I believe we have talked about) and it might be wroth to catch up on that when we are all in London in 2 weeks.

Looking forward to seeing the results of your work soon!

@ashfurrow
Copy link

This is great! I like the changes and the next steps.

Not to throw a wrench in things, but I would like to mention the Moya contributor guidelines that @orta and I helped develop. I have rolled out those guidelines successfully in RxSwiftCommunity, a very similar GitHub organization to react-native-community.

The tl;dr of the Moya guidelines are: when someone gets their first pull request merged, they get invited to the org. We totally automate this invitation process with Peril. This gives them a sense of ownership and motivates them to continue contributing (and to help review issues and pull requests, the less glamorous parts of OSS). I know react-native-community is operating a larger scale than Moya or the RxSwiftCommunity, but I'm very excited at the prospect of seeing these guidelines rolled out in RN.

@kelset kelset changed the title The React Native Community Manifesto The React Native Community guidelines Mar 20, 2019
@kelset
Copy link
Member Author

kelset commented Mar 20, 2019

hey everyone, thanks for all the feedback - after IRL conversations among FB members and the other members of the RNComm, we agreed that it's actually best to have this as its own separate repo, which has been already created:

https://github.com/react-native-community/meta

Also, we have removed the "manifesto" wording because it has some negative connotation is some cultures and we want to avoid issues because of that.

You'll also be able to find "stubs" for the guidelines we were already considering, so that you can check what each .md will be about - the details will be filled & discussed through PRs.

See you over there 👋

@kelset kelset closed this Mar 20, 2019
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Mar 20, 2019
@kelset kelset deleted the chore/manifesto branch June 12, 2019 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💡 Proposal This label identifies a proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants