-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed proguard rule for Hermes is not specified in the upgrade helper for 0.62. #19
Changed proguard rule for Hermes is not specified in the upgrade helper for 0.62. #19
Comments
Where is that change exactly? I couldn't find this in a new project. |
In the React Native documentation of 0.61,
In the documentation of 0.62 (https://reactnative.dev/docs/hermes), the Proguard rule is updated:
I think this change was made because 0.62 uses Hermes 0.4.0. However, I spent hours struggling with a crash bug because this Proguard.rule change was not specified in the update helper. If it is specified somewhere, it should be more salient for developers who are using Hermes. |
I wonder how we can add this to the upgrade-helper, I was thinking that we can add an inline comment here: (reason is that we can only add inline comments on diffs) And maybe add this issue at the top with a title like "Upgrade proguard rule for Hermes". Thoughts on this @muclipse @pvinis? |
Right. I checked the I feel this change might be more suitable in the releases changelog. For now, probably the best we can do is what @lucasbento said, and we can add a comment or a note on the 0.62 upgrade helper. |
Yeah, this is probably because the template does not use Hermes by default.
Agreed, cc @alloy. |
I agree, @alloy. Also,
cc @pvinis Another good place would be adding a comment in the block comment in android/build.gradle (file) above:
|
Hmm, yeah we actually went back and forth on this in the CHANGELOG react-native-community/releases#166 (comment) but dropped the ball in the end. Thanks for the reminder, added this react-native-community/releases#182 |
Eloy's PR is now merged, I guess we can close this? :) |
We still have some work to do on Upgrade-Helper side, will be done today |
Added a comment to Upgrade-Helper to mention this change at react-native-community/upgrade-helper#224 and it should be up in prod in a few minutes. Thank you so much for reporting this @muclipse, this will probably help a lot of people! |
Feature Request
The new proguard rule for using Hermes:
-keep class com.facebook.jni.** { *; }
is not mentioned in the upgrade helper for 0.62.
Why it is needed
Omitting this update makes the Android release app with Hermes and Proguard crashes on startup:
The text was updated successfully, but these errors were encountered: