Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): fix crash in getIpAddressSync #631

Merged

Commits on Oct 14, 2022

  1. fix(windows): fix crash in getIpAddressSync

    Even if not properly documented, some properties of
    `windows.networking.connectivity.connectionprofile` can throw.
    It's the case of `NetworkAdapter` since it's then calling
    `check_hresult` which will throw if the returned hresult is an error one.
    
    Since `RNCNetInfo::getIpAddressSync` is marked as `noexcept`, any exception
    thrown in this method will call `std::terminate`.
    
    This commit is to return `"unknown"` in this case.
    aironefr committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    4fe5df8 View commit details
    Browse the repository at this point in the history