Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushNotificationiOS crashes app for iOS 14 #195

Open
chahinaghrim opened this issue Oct 16, 2020 · 11 comments
Open

PushNotificationiOS crashes app for iOS 14 #195

chahinaghrim opened this issue Oct 16, 2020 · 11 comments
Labels
bug Something isn't working Help Wanted :octocat:

Comments

@chahinaghrim
Copy link

Current Live App uses React-Native : 0.62

We currently use the PushNotificationiOS service for changing the badge count of our app. Currently, whenever a user that has an iPhone with iOS 14 gets a notification, the app gets following error and crashes the app:

img_3167cef17973-1

For all users below iOS 14, the service works well.
Even when upgrading react-native to 0.63 and upgrading PushNotificationIOS to 1.6.0 , it keeps crashing the app.

Need help asap. Thanks in advance!

@ghasemikasra39
Copy link

I am facing the same behaviour on react native 0.63.3, ios 14.0.1, PushNotificationIOS 1.6.0. Any solution?

@hasfoug
Copy link

hasfoug commented Oct 19, 2020

Same for me, after upgrading to IOS 14

@Naturalclar Naturalclar added bug Something isn't working Help Wanted :octocat: labels Oct 19, 2020
@alon7
Copy link

alon7 commented Oct 24, 2020

Same for me, I had to patch the package to remove the completionHandler as recommended above

@fatihyildizhan
Copy link

@ghasemikasra39 upgrade to 1.7.1. Remote notification is working for me with rn 0.63.3 and iOS 14.0.1

@douglasdc
Copy link

Same for me, I had to patch the package to remove the completionHandler as recommended above

Patching to remove the call of completionHandler, the remote notification still working?

@raldred
Copy link

raldred commented Nov 13, 2020

Is this similar to #163
Can it be patched in the same way?
#234

@Naturalclar
Copy link
Collaborator

I've released 1.7.5-beta.0 with potential fix for this.
I wasn't able to reproduce the crash with the original package, so could someone verify that this change fixes the crash?

@douglasdc
Copy link

douglasdc commented Nov 23, 2020

I've released 1.7.5-beta.0 with potential fix for this.
I wasn't able to reproduce the crash with the original package, so could someone verify that this change fixes the crash?

Hei, I tested with that beta and it keeps happening.
I have used that package as dependency of push-notification to trigger a local notification.

The android package request the following use notification.finish(PushNotificationIOS.FetchResult.NoData); and that is what is causing the trouble, removing it, or commenting the handler solves that issue.

The error:
Screen Shot 2020-11-23 at 10 26 50

@Lkubok
Copy link

Lkubok commented Dec 9, 2020

upgrade version 1.8.0 fixes this problem. tested on iOS 14.2, 14.3 and react-native-0.64.rc1

@saadalvi92
Copy link

React-native push notification ios Causes app crash for me in ios 14 and pushNotification Ios 1.8.0 . The App Crashed when the Notification Registers in AppDelicate.m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Help Wanted :octocat:
Projects
None yet
Development

No branches or pull requests

11 participants