Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 search UX #14

Open
slorber opened this issue Sep 11, 2020 · 3 comments
Open

v2 search UX #14

slorber opened this issue Sep 11, 2020 · 3 comments

Comments

@slorber
Copy link

slorber commented Sep 11, 2020

Description

We need to figure out a good search experience for v2 site.

@Simek I'll let you explain the exact need, but as far as I understand, if a component exist in v0.63 and not in v0.64, we should still be able to search it while browsing 0.64

There's an Algolia option that could be useful for that: https://www.algolia.com/doc/api-reference/api-parameters/optionalFilters/

But I see 2 problems:

  • older versions (< 0.55) are archived, so they won't appear anyway
  • afaik optionalFilters will not filter duplicates across versions, which may produce weird search results

This is also related to a broader docusaurus subject where we should allow contextual search. If a user is in v0.62 we should probably present him v0.62 search results in priority (facebook/docusaurus#3396)

@slorber slorber changed the title v2 search v2 search UX Sep 11, 2020
@rachelnabors
Copy link

Is this behind the duplicate entries here?

Screenshot 2020-09-24 at 23 07 14

Personally, I feel the search bar should only search the version you're on. Using an older version? Switch to that version, use that search bar. But, was there a conversation about this with points already?

@slorber
Copy link
Author

slorber commented Sep 29, 2020

Hi @rachelnabors

Yes this is related to this duplicate entries problem here, and should be solved with facebook/docusaurus#3396

I also like the idea that you only search the current version you are on, as it's simpler, and expected, so if you validate this behavior it's easier for us to add this to RN website v2.

But it's not the current legacy v1 behavior, that keeps pages of older versions around (which has also been reported by some v1 users as a long standing bug, not a feature). @Simek mentioned that it might be important to be on v0.64 and be able to search for deprecated features from v0.56 etc, which is an unintended consequence for the legacy v1 behavior. If we can avoid being retrocompatible on this behavior, its better for me 😅

@slorber
Copy link
Author

slorber commented Oct 15, 2020

Contextual search merged, new release coming soon:

facebook/docusaurus#3550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants