fix: iPad / horizontal layout works as expected in BottomTabBar

react-navigation · Aug 18, 2019 · 3bb5ec4 · 3bb5ec4
1 parent 6e35ca4
commit 3bb5ec4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/bottom-tabs/src/views/BottomTabBar.js b/packages/bottom-tabs/src/views/BottomTabBar.js
@@ -129,7 +129,6 @@ class TabBarBottom extends React.Component<Props> {
         renderIcon={renderIcon}
         style={[
           styles.iconWithExplicitHeight,
-          styles.iconWithLabel,
           showLabel === false && !horizontal && styles.iconWithoutLabel,
           showLabel !== false && !horizontal && styles.iconWithLabel,
         ]}
@@ -213,7 +212,6 @@ class TabBarBottom extends React.Component<Props> {
                   this._shouldUseHorizontalLabels()
                     ? styles.tabLandscape
                     : styles.tabPortrait,
-                  styles.tabPortrait,
                   tabStyle,
                 ]}
               >

diff --git a/packages/bottom-tabs/src/views/CrossFadeIcon.js b/packages/bottom-tabs/src/views/CrossFadeIcon.js
@@ -59,5 +59,7 @@ const styles = StyleSheet.create({
     justifyContent: 'center',
     height: '100%',
     width: '100%',
+    // Workaround for react-native >= 0.54 layout bug
+    minWidth: 25,
   },
 });