Merge branch 'main' into add-close-accessibility-tap-area

react-navigation · Feb 12, 2023 · 63229a7 · 63229a7
2 parents c48f2f0 + d7ef2bf
commit 63229a7
Show file tree

Hide file tree

Showing 23 changed files with 73 additions and 24 deletions.
diff --git a/.github/workflows/check-repro.yml b/.github/workflows/check-repro.yml
@@ -52,8 +52,21 @@ jobs:
                 return;
               }
 
-            const body =
-              "Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a [snack.expo.dev](https://snack.expo.dev) link, a [www.typescriptlang.org/play](https://www.typescriptlang.org/play) link or link to a GitHub repo under your username).\n\nCan you provide a [minimal repro](https://stackoverflow.com/help/minimal-reproducible-example) which demonstrates the issue? Please try to keep the repro as small as possible and make sure that we can run it without additional setup.\n\nA repro will help us debug the issue. The issue will be closed automatically after a while if you don't provide a repro.";
+            const body = `Hey @${user}! Thanks for opening the issue. It seems that the issue doesn't contain a link to a repro.
+
+            **The best way to get attention to your issue is to provide an easy way for a developer to reproduce the issue.**
+
+            You can provide a repro using any of the following:
+
+            - [Expo Snack](https://snack.expo.io)
+            - [TypeScript Playground](https://www.typescriptlang.org/play)
+            - GitHub repo under your username
+
+            A snack link is preferred since it's the easiest way to both create and share a repro. If it's not possible to create a repro using a snack, link to a GitHub repo under your username is a good alternative. **Don't link to a branch or specific file etc.** as it won't be detected.
+
+            Try to keep the repro as small as possible by narrowing down the minimal amount of code needed to reproduce the issue. **Don't link to your entire project or a project containing code unrelated to the issue.** See ["How to create a Minimal, Reproducible Example"](https://stackoverflow.com/help/minimal-reproducible-example) for more information.
+
+            You can edit your original issue to include a link to the repro, or leave it as a comment. **The issue will be closed automatically after a while** if you don't provide a repro.`
 
               const comments = await github.issues.listComments({
                 issue_number: context.issue.number,

diff --git a/.github/workflows/closed-issue.yml b/.github/workflows/closed-issue.yml
@@ -14,6 +14,7 @@ jobs:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
               const body = "Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro.";
+
               const comments = await github.issues.listComments({
                 issue_number: context.issue.number,
                 owner: context.repo.owner,

diff --git a/.github/workflows/first-pull-request.yml b/.github/workflows/first-pull-request.yml
@@ -31,7 +31,7 @@ jobs:
               }
             }
 
-            const body = `Hey ${creator}! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our [contribution guidelines](https://github.com/react-navigation/react-navigation/blob/main/CONTRIBUTING.md).`;
+            const body = `Hey @${creator}! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our [contribution guidelines](https://github.com/react-navigation/react-navigation/blob/main/CONTRIBUTING.md).`;
 
             const comments = await github.issues.listComments({
               issue_number: context.issue.number,

diff --git a/packages/bottom-tabs/CHANGELOG.md b/packages/bottom-tabs/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.5.4](https://github.com/react-navigation/react-navigation/compare/@react-navigation/bottom-tabs@6.5.3...@react-navigation/bottom-tabs@6.5.4) (2023-01-31)
+
+**Note:** Version bump only for package @react-navigation/bottom-tabs
+
 ## [6.5.3](https://github.com/react-navigation/react-navigation/compare/@react-navigation/bottom-tabs@6.5.2...@react-navigation/bottom-tabs@6.5.3) (2023-01-10)
 
 **Note:** Version bump only for package @react-navigation/bottom-tabs

diff --git a/packages/bottom-tabs/package.json b/packages/bottom-tabs/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@react-navigation/bottom-tabs",
   "description": "Bottom tab navigator following iOS design guidelines",
-  "version": "6.5.3",
+  "version": "6.5.4",
   "keywords": [
     "react-native-component",
     "react-component",
@@ -36,7 +36,7 @@
     "clean": "del lib"
   },
   "dependencies": {
-    "@react-navigation/elements": "^1.3.13",
+    "@react-navigation/elements": "^1.3.14",
     "color": "^4.2.3",
     "warn-once": "^0.1.0"
   },

diff --git a/packages/drawer/CHANGELOG.md b/packages/drawer/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.5.8](https://github.com/react-navigation/react-navigation/compare/@react-navigation/drawer@6.5.7...@react-navigation/drawer@6.5.8) (2023-01-31)
+
+**Note:** Version bump only for package @react-navigation/drawer
+
 ## [6.5.7](https://github.com/react-navigation/react-navigation/compare/@react-navigation/drawer@6.5.6...@react-navigation/drawer@6.5.7) (2023-01-10)
 
 **Note:** Version bump only for package @react-navigation/drawer

diff --git a/packages/drawer/package.json b/packages/drawer/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@react-navigation/drawer",
   "description": "Drawer navigator component with animated transitions and gesturess",
-  "version": "6.5.7",
+  "version": "6.5.8",
   "keywords": [
     "react-native-component",
     "react-component",
@@ -41,7 +41,7 @@
     "clean": "del lib"
   },
   "dependencies": {
-    "@react-navigation/elements": "^1.3.13",
+    "@react-navigation/elements": "^1.3.14",
     "color": "^4.2.3",
     "warn-once": "^0.1.0"
   },

diff --git a/packages/elements/CHANGELOG.md b/packages/elements/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.3.14](https://github.com/react-navigation/react-navigation/compare/@react-navigation/elements@1.3.13...@react-navigation/elements@1.3.14) (2023-01-31)
+
+**Note:** Version bump only for package @react-navigation/elements
+
 ## [1.3.13](https://github.com/react-navigation/react-navigation/compare/@react-navigation/elements@1.3.12...@react-navigation/elements@1.3.13) (2023-01-10)
 
 **Note:** Version bump only for package @react-navigation/elements

diff --git a/packages/elements/package.json b/packages/elements/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@react-navigation/elements",
   "description": "UI Components for React Navigation",
-  "version": "1.3.13",
+  "version": "1.3.14",
   "keywords": [
     "react-native",
     "react-navigation",

diff --git a/packages/material-bottom-tabs/CHANGELOG.md b/packages/material-bottom-tabs/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.2.12](https://github.com/react-navigation/react-navigation/compare/@react-navigation/material-bottom-tabs@6.2.11...@react-navigation/material-bottom-tabs@6.2.12) (2023-01-31)
+
+**Note:** Version bump only for package @react-navigation/material-bottom-tabs
+
 ## [6.2.11](https://github.com/react-navigation/react-navigation/compare/@react-navigation/material-bottom-tabs@6.2.10...@react-navigation/material-bottom-tabs@6.2.11) (2023-01-10)
 
 **Note:** Version bump only for package @react-navigation/material-bottom-tabs

diff --git a/packages/material-bottom-tabs/package.json b/packages/material-bottom-tabs/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@react-navigation/material-bottom-tabs",
   "description": "Integration for bottom navigation component from react-native-paper",
-  "version": "6.2.11",
+  "version": "6.2.12",
   "keywords": [
     "react-native-component",
     "react-component",
@@ -41,7 +41,7 @@
     "clean": "del lib"
   },
   "dependencies": {
-    "@react-navigation/elements": "^1.3.13"
+    "@react-navigation/elements": "^1.3.14"
   },
   "devDependencies": {
     "@react-navigation/native": "workspace:^",

diff --git a/packages/material-top-tabs/CHANGELOG.md b/packages/material-top-tabs/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.5.3](https://github.com/react-navigation/react-navigation/compare/@react-navigation/material-top-tabs@6.5.2...@react-navigation/material-top-tabs@6.5.3) (2023-01-31)
+
+**Note:** Version bump only for package @react-navigation/material-top-tabs
+
 ## [6.5.2](https://github.com/react-navigation/react-navigation/compare/@react-navigation/material-top-tabs@6.5.1...@react-navigation/material-top-tabs@6.5.2) (2023-01-10)
 
 **Note:** Version bump only for package @react-navigation/material-top-tabs

diff --git a/packages/material-top-tabs/package.json b/packages/material-top-tabs/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@react-navigation/material-top-tabs",
   "description": "Integration for the animated tab view component from react-native-tab-view",
-  "version": "6.5.2",
+  "version": "6.5.3",
   "keywords": [
     "react-native-component",
     "react-component",

diff --git a/packages/native-stack/CHANGELOG.md b/packages/native-stack/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.9.9](https://github.com/react-navigation/react-navigation/compare/@react-navigation/native-stack@6.9.8...@react-navigation/native-stack@6.9.9) (2023-01-31)
+
+**Note:** Version bump only for package @react-navigation/native-stack
+
 ## [6.9.8](https://github.com/react-navigation/react-navigation/compare/@react-navigation/native-stack@6.9.7...@react-navigation/native-stack@6.9.8) (2023-01-10)
 
 **Note:** Version bump only for package @react-navigation/native-stack

diff --git a/packages/native-stack/package.json b/packages/native-stack/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@react-navigation/native-stack",
   "description": "Native stack navigator using react-native-screens",
-  "version": "6.9.8",
+  "version": "6.9.9",
   "keywords": [
     "react-native-component",
     "react-component",
@@ -41,7 +41,7 @@
     "clean": "del lib"
   },
   "dependencies": {
-    "@react-navigation/elements": "^1.3.13",
+    "@react-navigation/elements": "^1.3.14",
     "warn-once": "^0.1.0"
   },
   "devDependencies": {

diff --git a/packages/native-stack/src/views/HeaderConfig.tsx b/packages/native-stack/src/views/HeaderConfig.tsx
@@ -279,6 +279,7 @@ const styles = StyleSheet.create({
     left: 0,
     right: 0,
     zIndex: 1,
+    elevation: 1,
   },
   background: {
     overflow: 'hidden',

diff --git a/packages/native/CHANGELOG.md b/packages/native/CHANGELOG.md
@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.1.3](https://github.com/react-navigation/react-navigation/compare/@react-navigation/native@6.1.2...@react-navigation/native@6.1.3) (2023-01-31)
+
+### Bug Fixes
+
+* don't modify browser history on re-render ([79d8dc1](https://github.com/react-navigation/react-navigation/commit/79d8dc107aaadf4923024f8b122c0b55e1079706)) - by @satya164
+
 ## [6.1.2](https://github.com/react-navigation/react-navigation/compare/@react-navigation/native@6.1.1...@react-navigation/native@6.1.2) (2023-01-10)
 
 **Note:** Version bump only for package @react-navigation/native

diff --git a/packages/native/package.json b/packages/native/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@react-navigation/native",
   "description": "React Native integration for React Navigation",
-  "version": "6.1.2",
+  "version": "6.1.3",
   "keywords": [
     "react-native",
     "react-navigation",

diff --git a/packages/native/src/useLinking.tsx b/packages/native/src/useLinking.tsx
@@ -412,7 +412,7 @@ export default function useLinking(
     // This could happen since `history.go(n)` is asynchronous
     // If `pushState` or `replaceState` were called before `history.go(n)` completes, it'll mess stuff up
     return ref.current?.addListener('state', series(onStateChange));
-  });
+  }, [enabled, history, ref]);
 
   return {
     getInitialState,

diff --git a/packages/stack/CHANGELOG.md b/packages/stack/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.3.12](https://github.com/react-navigation/react-navigation/compare/@react-navigation/stack@6.3.11...@react-navigation/stack@6.3.12) (2023-01-31)
+
+**Note:** Version bump only for package @react-navigation/stack
+
 ## [6.3.11](https://github.com/react-navigation/react-navigation/compare/@react-navigation/stack@6.3.10...@react-navigation/stack@6.3.11) (2023-01-10)
 
 **Note:** Version bump only for package @react-navigation/stack

diff --git a/packages/stack/package.json b/packages/stack/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@react-navigation/stack",
   "description": "Stack navigator component for iOS and Android with animated transitions and gestures",
-  "version": "6.3.11",
+  "version": "6.3.12",
   "keywords": [
     "react-native-component",
     "react-component",
@@ -40,7 +40,7 @@
     "clean": "del lib"
   },
   "dependencies": {
-    "@react-navigation/elements": "^1.3.13",
+    "@react-navigation/elements": "^1.3.14",
     "color": "^4.2.3",
     "warn-once": "^0.1.0"
   },

diff --git a/packages/stack/src/types.tsx b/packages/stack/src/types.tsx
@@ -165,7 +165,7 @@ export type StackHeaderOptions = Omit<
   /**
    * Whether the back button title should be visible or not.
    *
-   * Defaults to `true` on iOS, `false on Android.
+   * Defaults to `true` on iOS, `false` on Android.
    */
   headerBackTitleVisible?: boolean;
   /**

diff --git a/yarn.lock b/yarn.lock
@@ -4735,7 +4735,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@react-navigation/bottom-tabs@workspace:packages/bottom-tabs"
   dependencies:
-    "@react-navigation/elements": ^1.3.13
+    "@react-navigation/elements": ^1.3.14
     "@react-navigation/native": "workspace:^"
     "@testing-library/react-native": ^11.5.0
     "@types/color": ^3.0.1
@@ -4808,7 +4808,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@react-navigation/drawer@workspace:packages/drawer"
   dependencies:
-    "@react-navigation/elements": ^1.3.13
+    "@react-navigation/elements": ^1.3.14
     "@react-navigation/native": "workspace:^"
     "@testing-library/react-native": ^11.5.0
     "@types/react": ~18.0.0
@@ -4835,7 +4835,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@react-navigation/elements@^1.3.13, @react-navigation/elements@workspace:packages/elements":
+"@react-navigation/elements@^1.3.14, @react-navigation/elements@workspace:packages/elements":
   version: 0.0.0-use.local
   resolution: "@react-navigation/elements@workspace:packages/elements"
   dependencies:
@@ -4921,7 +4921,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@react-navigation/material-bottom-tabs@workspace:packages/material-bottom-tabs"
   dependencies:
-    "@react-navigation/elements": ^1.3.13
+    "@react-navigation/elements": ^1.3.14
     "@react-navigation/native": "workspace:^"
     "@testing-library/react-native": ^11.5.0
     "@types/react": ~18.0.0
@@ -4975,7 +4975,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@react-navigation/native-stack@workspace:packages/native-stack"
   dependencies:
-    "@react-navigation/elements": ^1.3.13
+    "@react-navigation/elements": ^1.3.14
     "@react-navigation/native": "workspace:^"
     "@testing-library/react-native": ^11.5.0
     "@types/react": ~18.0.0
@@ -5035,7 +5035,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@react-navigation/stack@workspace:packages/stack"
   dependencies:
-    "@react-navigation/elements": ^1.3.13
+    "@react-navigation/elements": ^1.3.14
     "@react-navigation/native": "workspace:^"
     "@testing-library/react-native": ^11.5.0
     "@types/color": ^3.0.1