feat: add children prop to tab bar indicator component #11566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to be able to display a
<LinearGradient/>
component inside the<TabBarIndicator/>
. While you can use therenderIndicator
prop onTabBar
, you cannot render a wrapper or child of the indicator and have it inherit the animation the library already provides. By providing achildren
option toTabBarIndicator
, this problem is easily solved.Test plan
Tests all still pass and to test this specific change, try something like this:
This allows more complex components to be animated and accurately denote the active tab. I have some screenshots of an example where I'm using a
<LinearGradient/>
container to display a gradient indicator - something not possible with just a style object.