Fix drawer toggle #3191
Merged
Fix drawer toggle #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GantMan
suggested changes
Jan 5, 2018
|
I have the code updated --- so just the double equals to a triple (our JavaScript curse) please. |
Codecov Report
@@ Coverage Diff @@
## master #3191 +/- ##
=======================================
Coverage 71.88% 71.88%
=======================================
Files 51 51
Lines 1519 1519
Branches 382 382
=======================================
Hits 1092 1092
Misses 337 337
Partials 90 90
Continue to review full report at Codecov.
|
|
Changed double equals to a triple in fix_drawer_toggle branch. |
GantMan
approved these changes
Jan 6, 2018
tzkoshi
pushed a commit
to tzkoshi/react-navigation
that referenced
this pull request
Jan 22, 2018
* Fixed drawer toggle * Fixed drawer toggle * Update DrawerView.js
sourcecode911
pushed a commit
to sourcecode911/react-navigation
that referenced
this pull request
Mar 9, 2020
* Fixed drawer toggle * Fixed drawer toggle * Update DrawerView.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drawer does not toggle as per this issue.
this._drawer.state.drawerShownseems to be available only on iOS?Test plan (required)
Works on both iOS and Android (Issue didn't exist in iOS in the first place)