createNavigationContainer: rethrow the error instead of creating a new one #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w one Creating a new error makes the stack unreadable in sentry, because the stack is stringified when the error is cast to string to create a new one. Is there another reason to do that ? Alternative possible solution would be to add a method to be able to handle the error ourselves ?
Codecov Report
@@ Coverage Diff @@
## master #4533 +/- ##
======================================
Coverage 68.2% 68.2%
======================================
Files 53 53
Lines 1739 1739
======================================
Hits 1186 1186
Misses 553 553
Continue to review full report at Codecov.
|
|
NavigationPlayground for 9ee05f6 has been deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new error makes the stack unreadable in sentry, because the stack is stringified when the error is cast to string to create a new one.
Is there another reason to do that ?
Alternative possible solution would be to add a method to be able to handle the error ourselves ?