Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createNavigationContainer: rethrow the error instead of creating a new one #4533

Merged
merged 1 commit into from Jun 20, 2018
Merged

createNavigationContainer: rethrow the error instead of creating a new one #4533

merged 1 commit into from Jun 20, 2018

Commits on Jun 19, 2018

  1. createNavigationContainer: rethrow the error instead of creating a ne… 

    …w one

Creating a new error makes the stack unreadable in sentry, because the stack is stringified when the error is cast to string to create a new one.
Is there another reason to do that ?
Alternative possible solution would be to add a method to be able to handle the error ourselves ?
    @christophehurpeau
    christophehurpeau committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    9ee05f6 View commit details
    Browse the repository at this point in the history