Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export StackViewTransitionConfigs #4761

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Export StackViewTransitionConfigs #4761

merged 2 commits into from
Jul 25, 2018

Conversation

timwangdev
Copy link

@timwangdev timwangdev commented Jul 25, 2018

Motivation

Export StackViewTransitionConfigs is very handy for custom transitionConfig in navigator options to reuse the default ones.

Test plan

The code must pass tests.

Code formatting

Done

Changelog

Export StackViewTransitionConfigs to allow you to extend default config in custom transition configs.

CHANGELOG.md

@react-navigation-ci
Copy link

1 similar comment
@react-navigation-ci
Copy link

@codecov-io
Copy link

Codecov Report

Merging #4761 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4761      +/-   ##
==========================================
- Coverage   67.75%   67.72%   -0.04%     
==========================================
  Files          57       57              
  Lines        1833     1834       +1     
==========================================
  Hits         1242     1242              
- Misses        591      592       +1
Impacted Files Coverage Δ
src/views/StackView/StackViewTransitionConfigs.js 66.66% <ø> (ø) ⬆️
src/react-navigation.js 13.72% <0%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67233dc...e64642e. Read the comment docs.

@brentvatne brentvatne merged commit 9175118 into react-navigation:master Jul 25, 2018
@brentvatne
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants