Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript declaration file. #5276

Closed
wants to merge 10 commits into from
Closed

Add TypeScript declaration file. #5276

wants to merge 10 commits into from

Commits on Nov 23, 2018

  1. Add TypeScript declaration file. 

    As discussed in [this issue](https://github.com/react-navigation/react-navigation-core/issues/2) we should manage the TypeScript typings from within react-navigation.

This file extends the old DefinitelyTyped file:

What I added (and needs to be checked / reviewed): `unmountInactiveRoutes`, `drawerType` and missing `contentOptions` for `DrawerItems`.
Added `defaultNavigationOptions`.
Added default params inside route definitions.
Added 'headerBackgroundTransitionPreset'.
Added `cardOverlayEnabled` and `cardShadowEnabled`.

What I couldn't add:
The support for React Hooks (I didn't find the code in V3).
Type definitions for `createAppContainer` (I didn't have time to look into it and understand the code).
    @janhesters
    janhesters committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    63b87d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. Merge branch 'master' into patch-1

    @janhesters
    janhesters committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    97d1302 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. add createAppContainer 

    Co-Authored-By: janhesters <31096420+janhesters@users.noreply.github.com>
    @BrendonSled @janhesters
    BrendonSled and janhesters committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    18bcdb1 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. add type

    @bySabi
    bySabi committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    223c6b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. improve some typings

    @bySabi
    bySabi committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    03457fc View commit details
    Browse the repository at this point in the history

  2. add "types" to package.json

    @bySabi
    bySabi committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    6b69ab3 View commit details
    Browse the repository at this point in the history

  3. Update src/index.d.ts 

    Co-Authored-By: janhesters <31096420+janhesters@users.noreply.github.com>
    @BrendonSled @janhesters
    BrendonSled and janhesters committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    8c5b452 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2018

  1. Merge pull request #1 from bySabi/patch-1 

    Patch 1
    @janhesters
    janhesters committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    efe43d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Migrate Playground to TypeScript.

    @janhesters
    janhesters committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    a84fe56 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. Merge with current DefinitelyTyped types

    @janhesters
    janhesters committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    d8821dd View commit details
    Browse the repository at this point in the history