Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix comments for gestureResponseDistance #8954

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

davidpett
Copy link
Contributor

gestureResponseDistance vertical and horizontal documentations were swapped

@netlify
Copy link

netlify bot commented Oct 15, 2020

Deploy preview for react-navigation-example ready!

Built with commit 3815c27

https://deploy-preview-8954--react-navigation-example.netlify.app

@codecov-io
Copy link

Codecov Report

Merging #8954 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8954   +/-   ##
=======================================
  Coverage   74.24%   74.24%           
=======================================
  Files         131      131           
  Lines        3231     3231           
  Branches      998      998           
=======================================
  Hits         2399     2399           
  Misses        727      727           
  Partials      105      105           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ff5a9...5c8e908. Read the comment docs.

the type descriptions for vertical/horizontal were swapped
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@satya164 satya164 changed the title Update comments in types.tsx docs: fix comments for gestureResponseDistance Oct 21, 2020
@satya164 satya164 merged commit 8585f97 into react-navigation:main Oct 21, 2020
joshuapinter pushed a commit to cntral/react-navigation that referenced this pull request Sep 29, 2021
gestureResponseDistance vertical and horizontal documentations were swapped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants