Install WartRemover For #331 #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
This hopefully makes compilation faster, avoids a scala 3 documentation slowdown, re-enables sealed traits, etc. This is test up through commands module Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Also adjust testkit tests because resolution is working better and also affects usage and output change based on new or better messages Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
And its test fails randomly Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
* Abandon the old algorithm * Base algorithm on finding the "anchor" node in the model * Anchor node can be: * "Root" (root of model), * First Ancestor (of the PathId) that matches PathId first element * A unique element in the SymTab that matches PathId first element * Don't resolve every path reference every time, use the resolution map built so far to resolve common paths. * Refactor into functions with names that make sense * Still passes all path resolution tests in all modules. Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
* Testing passes for Reid (only) .. hardcoded paths * can specify both options and the .conf file * auto-configures libraries for testing * Can use riddl-testkit capabilities Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Signed-off-by: reidspencer <reid.spencer@yoppworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use WartRemover to identify code issues and in response either: