Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Direct Passthrough Users #12

Closed
wants to merge 3 commits into from
Closed

Add Direct Passthrough Users #12

wants to merge 3 commits into from

Conversation

dkabot
Copy link

@dkabot dkabot commented Nov 13, 2015

Being a rebel, I plan to see if I can use Discord-IRC to basically set up Discord as a personal, nice IRC client. In such a case, the before every message becomes redundant and annoying. Since just ripping out that logic in a personal fork seemed like a bad idea (what if someone else does happen to connect and type something? I don't want to be impersonated!) I made this instead.

Discord user IDs can be added to an optional "passthroughUserIDs" section of the configuration, and if that user sends a message, it just sends through the bot directly. No , no "Command sent by X from Discord", they just talk through the bot. If it doesn't exist in the config, or the user ID isn't in it, it acts as usual.

While what I'm trying to do isn't the goal of the project, I thought this might happen to have its uses. This is definitely a very niche thing to have, but since it works I figured why not PR it. My apologies if this is too out there.

(I'm definitely not a node.js dev, so I might have missed an easier way to do this, though the npm run lint didn't output anything. Additional apologies if there's anything obviously off.)

PassthroughUsers are User IDs optionally defined in the config which won't have their username sent with bot messages, thus speaking "as the bot".
@ekmartin
Copy link
Member

Hi, and thanks for the pull request! This definitely looks like a clean solution, but as you're saying I'm a bit unsure if it's within the project's goal. I feel like if you want to use Discord as an IRC client, there's much cooler ways to do it.

For example, what happens to private messages? Right now they'll just get absorbed, and you'll never know they arrived. If you had a private Discord server as your IRC bridge you could instead print them out, for example with a prefix that shows that it's a private message, and who they're from. Then you could also make it possible to send PMs to people on IRC, maybe through a specific command sent to the Discord bot user (i.e. !message <username> hi).

You could also implement other special commands, like for listing all the users in the IRC channel, showing the message of the day and so on.

If this is something you'd want to spend time building I wouldn't mind at all if you used discord-irc as a basis, i.e. by creating a new repository with a different name, but with discord-irc's existing code.

@dkabot
Copy link
Author

dkabot commented Nov 14, 2015

Yeah, after toying with it a bit it's a tad bit of a mess to use in this
capacity, but it might be fun to mess with in the future.

It was at least interesting, though.

On Sat, Nov 14, 2015 at 6:46 PM, Martin Ek notifications@github.com wrote:

Hi, and thanks for the pull request! This definitely looks like a clean
solution, but as you're saying I'm a bit unsure if it's within the
project's goal. I feel like if you want to use Discord as an IRC client,
there's much cooler ways to do it.

For example, what happens to private messages? Right now they'll just get
absorbed, and you'll never know they arrived. If you had a private Discord
server as your IRC bridge you could instead print them out, for example
with a prefix that shows that it's a private message, and who they're from.
Then you could also make it possible to send PMs to people on IRC, maybe
through a specific command sent to the Discord bot user (i.e. !message
hi).

You could also implement other special commands, like for listing all the
users in the IRC channel, showing the message of the day and so on.

If this is something you'd want to spend time building I wouldn't mind at
all if you used discord-irc as a basis, i.e. by creating a new repository
with a different name, but with discord-irc's existing code.


Reply to this email directly or view it on GitHub
#12 (comment)
.

@ekmartin
Copy link
Member

Yep, I see. Feel free to PM me with questions on Discord (ekmartin) if you give it a try in the future 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants