Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix configuration environment variables #4

Open
mrksmrtn opened this issue Oct 27, 2020 · 0 comments
Open

Prefix configuration environment variables #4

mrksmrtn opened this issue Oct 27, 2020 · 0 comments

Comments

@mrksmrtn
Copy link
Collaborator

The configuration package looks up keys from env vars in addition to what is loaded from the JSON config. This is convenient for overriding values with the environment. However, these names can conflict with existing system environment variables if they happen to have the same name. E.g.: A restlib config key named PATH would end up with the system path ($PATH), which is very unlikely what a user would want.

The solution is to automatically prefix the env vars which should be used with restlib. Something like: RESTLIB_PATH. This will greatly reduce the risk of a conflict and a hard to debug problem. Config keys would continue to have no prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant