Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy develop branch to staging environment in ECS #355

Merged
merged 21 commits into from
Oct 2, 2018

Conversation

griggheo
Copy link
Contributor

@griggheo griggheo commented Oct 1, 2018

Impact: major
Type: feature

Issue

The CircleCI pipeline has been modified to use the latest version of the propel CLI in order to push the develop branch to the staging environment.

Breaking changes

Testing

  1. Perform starter kit functional testing against https://storefront.staging.reactioncommerce.com/

@griggheo griggheo requested a review from willopez October 1, 2018 21:16
@machikoyasuda
Copy link
Contributor

machikoyasuda commented Oct 1, 2018

I'm not sure if this comment is the right place to put it but it's related to our staging url

Currently, the app shows that we are using SOME_KEY as the Segment API Key:

screen shot 2018-10-01 at 11 17 08 am

Can we get a Segment test key and include it in the staging URL? It will help the team test internally, and also make it easier to demo Segment integration.

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willopez willopez merged commit a6db2ff into develop Oct 2, 2018
@willopez willopez deleted the circleci-propel-ecs branch October 2, 2018 19:14
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants