Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(340): catch Stripe Payment error and save error message #406

Merged
merged 9 commits into from
Nov 2, 2018

Conversation

machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Oct 25, 2018

Resolves #340
Impact: major
Type: feature

Issue

  • Issue: A customer does not know if a payment failed, and is stuck at the page when errors occur.
  • Feature: After a customer saves an invalid credit card and clicks Check Out, the customer should be taken back to the Cart page on Step 3, Payment, and an InlineAlert should appear with the error message.

Solution

  • - Catch Stripe payment error message
  • - Pass an alert object to CheckoutActions:
  • - Add InlineAlert to app
  • - Take user back to Step 3 and display InlineAlert
  • - Reset the payment form

Testing

  1. Test these Stripe cards pre-configured with errors: https://stripe.com/docs/testing#cards-responses

@machikoyasuda machikoyasuda force-pushed the feat-340-machikoyasuda-payment-error branch from c236716 to fd5aa6c Compare November 1, 2018 21:48
@machikoyasuda machikoyasuda changed the title WIP - fix: catch Stripe Payment error and save error message fix(340): catch Stripe Payment error and save error message Nov 1, 2018
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Looks good! There are a few undefined required prop warnings after checkout completes but that will need to be addressed in the component library.

@nnnnat nnnnat merged commit 744f283 into develop Nov 2, 2018
@nnnnat nnnnat deleted the feat-340-machikoyasuda-payment-error branch November 2, 2018 16:58
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants