Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show tax total in all summaries #424

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Nov 9, 2018

Impact: minor
Type: bugfix

Issue

Only 1 of the 4 places where CartSummary is used was showing the taxTotal amount. The others always showed -.

Solution

Now all summaries show the tax amount

Breaking changes

n/a

Testing

Must be tested against refactor-aldeed-split-tax-rates-plugin branch of Reaction API until it is merged.

  1. Configure and enable a tax service in Reaction operator UI.
  2. Configure a product variant to be taxable and have a taxable tax code.
  3. Add that product variant to your cart in starter kit storefront.
  4. Go to checkout and enter a shipping address.
  5. Verify that a tax amount shows in the summary on the right
  6. Go to /cart and verify that a tax amount shows there.
  7. Go back to checkout and finish checking out. Verify that a tax amount shows on the order summary after the order is placed.

Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@nnnnat nnnnat merged commit 2000729 into develop Nov 12, 2018
@nnnnat nnnnat deleted the fix-aldeed-show-tax-in-summary branch November 12, 2018 16:33
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants