fix: promotion disabled but still can appliable

Signed-off-by: vanpho93 <vanpho02@gmail.com>
reactioncommerce · Jan 16, 2023 · 07008ae · 07008ae
1 parent 79a70a0
commit 07008ae
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/packages/api-plugin-promotions/src/handlers/applyPromotions.js b/packages/api-plugin-promotions/src/handlers/applyPromotions.js
@@ -124,15 +124,17 @@ export default async function applyPromotions(context, cart) {
 
   let enhancedCart = enhanceCart(context, pluginPromotions.enhancers, cart);
   for (const promotion of unqualifiedPromotions) {
-    if (!promotion.enabled && canAddToCartMessages(promotion)) {
-      cartMessages.push(createCartMessage({
-        title: "The promotion no longer available",
-        subject: "promotion",
-        severity: "warning",
-        metaFields: {
-          promotionId: promotion._id
-        }
-      }));
+    if (!promotion.enabled) {
+      if (canAddToCartMessages(promotion)) {
+        cartMessages.push(createCartMessage({
+          title: "The promotion no longer available",
+          subject: "promotion",
+          severity: "warning",
+          metaFields: {
+            promotionId: promotion._id
+          }
+        }));
+      }
       continue;
     }