Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MultiSelect prop type "value" #2576

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Fix MultiSelect prop type "value" #2576

merged 1 commit into from
Jul 19, 2017

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Jul 19, 2017 •
edited
Loading

react-select expects value to be of type any. Updated prop type to match that case.

My greatest achievement yet.

@mikemurray
Update MultiSelect prop type value
6889db3 
Fix prop type value of MultiSelect to match values expected by underlying component.
@aaronjudd aaronjudd merged commit 54419b6 into development Jul 19, 2017
@aaronjudd aaronjudd deleted the multiselect-prop-type branch July 19, 2017 21:51
jshimko added a commit that referenced this pull request Jul 20, 2017
@jshimko
Merge branch 'development' into register-component-api
36eea76 
* development:
  Remove native bcrypt (#2571)
  Add Community pages (#2575)
  Update MultiSelect prop type value (#2576)

# Conflicts:
#	package.json
@spencern spencern mentioned this pull request Jul 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronjudd aaronjudd aaronjudd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemurray @aaronjudd