Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "PayPal Express isn't fully setup by default' bug #3027

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Fix "PayPal Express isn't fully setup by default' bug #3027

merged 1 commit into from
Oct 5, 2017

Conversation

efalayi
Copy link
Contributor

@efalayi efalayi commented Oct 4, 2017 •
edited
Loading

Resolves #3001
After enabling PayPal express, I'm forced to select when payment should be captured.

A default option is not selected because express_auth_and_capture is not registered in the database.

Fix
- Register `express_auth_and_capture` in database
- Rename all instances of `express_auth_and_capture` to `expressAuthAndCapture`. 
This was to fix an eslint error.
Test
Login as admin
Goto Payment options
Enable Paypal Express
Observe that the field labelled `Capture at time of Auth` has an already selected option: `Authorize, Capture on complete`

- register express_auth_and_capture in database
00b864e 
- change all instances of express_auth_and-capture to camel case
brent-hoover
brent-hoover approved these changes Oct 5, 2017
View reviewed changes
Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Verified fixed.

@brent-hoover brent-hoover merged commit 3b56547 into marketplace Oct 5, 2017
@brent-hoover brent-hoover deleted the esther-fix-issue-3001 branch October 5, 2017 00:17
@brent-hoover brent-hoover mentioned this pull request Oct 5, 2017
Closed
@spencern spencern mentioned this pull request Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brent-hoover brent-hoover brent-hoover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efalayi @brent-hoover