This one weird trick will fix your Shopify import problems #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikemurray this fixes the problems with the importer.. but it doesn't make sense to me as why it's fixing it. There are issues with the importer running afoul of Meteor fibers when the package.json file is not present, but this doesn't really feel like a clean fix to me. |
spencern
changed the title
|
Adding the WIP flag here because I want to re-write the way this works so that it's not dependent on whatever is happening with the package.json - it should work in either scenario. |
brent-hoover
approved these changes
Oct 16, 2017
brent-hoover
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the Shopify importer for me.
Not sure why that would be the case, but putting this up here for now, I'm gonna pull it down and run it through on a fresh install in a bit.