Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProductGridContaintainer should pass all properties to child component #3512

Merged
merged 1 commit into from
Jan 20, 2018
Merged

ProductGridContaintainer should pass all properties to child component #3512

merged 1 commit into from
Jan 20, 2018

Conversation

prinzdezibel
Copy link
Contributor

Closes #3511.

Per convention, all properties should be passed to child component:
https://reactjs.org/docs/higher-order-components.html#refs-arent-passed-through

This is enables us to use the HOC child component agnostic.

@prinzdezibel
Copy link
Contributor Author

@spencer @jshimko This is the second HOC that needs to pass the properties. Would be great to get this reviewed in a timely manner. Thanks!

@spencer
Copy link

spencer commented Jan 18, 2018

I don't think you're meaning to '@' me on this. #justsayin ;-)

@prinzdezibel
Copy link
Contributor Author

@spencer: Ooops, sorry :-)
Was missing an 'n' as in @spencern.

@prinzdezibel prinzdezibel mentioned this pull request Jan 19, 2018
Closed
@spencern spencern changed the base branch from master to release-1.6.5 January 20, 2018 00:22
@spencern spencern merged commit 8378c97 into release-1.6.5 Jan 20, 2018
@spencern spencern deleted the refactor-3464-productsGridContainer-should-pass-all-properties branch January 20, 2018 00:25
@spencern spencern mentioned this pull request Jan 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshimko jshimko jshimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prinzdezibel @spencer @jshimko @spencern