Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductGridContaintainer should pass all properties to child component #3512

Conversation

4 participants
@prinzdezibel
Copy link
Contributor

prinzdezibel commented Jan 18, 2018

Closes #3511.

Per convention, all properties should be passed to child component:
https://reactjs.org/docs/higher-order-components.html#refs-arent-passed-through

This is enables us to use the HOC child component agnostic.

@prinzdezibel prinzdezibel requested a review from jshimko Jan 18, 2018

@prinzdezibel

This comment has been minimized.

Copy link
Contributor Author

prinzdezibel commented Jan 18, 2018

@spencer @jshimko This is the second HOC that needs to pass the properties. Would be great to get this reviewed in a timely manner. Thanks!

@spencer

This comment has been minimized.

Copy link

spencer commented Jan 18, 2018

I don't think you're meaning to '@' me on this. #justsayin ;-)

@prinzdezibel

This comment has been minimized.

Copy link
Contributor Author

prinzdezibel commented Jan 18, 2018

@spencer: Ooops, sorry :-)
Was missing an 'n' as in @spencern.

@prinzdezibel prinzdezibel referenced this pull request Jan 19, 2018

Closed

Category grid #33

@spencern spencern changed the base branch from master to release-1.6.5 Jan 20, 2018

@spencern spencern merged commit 8378c97 into release-1.6.5 Jan 20, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the refactor-3464-productsGridContainer-should-pass-all-properties branch Jan 20, 2018

@spencern spencern referenced this pull request Jan 20, 2018

Merged

Release 1.6.5 #3525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.