(fix): Add permission checks to template method and publication #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjudd
previously requested changes
Jan 27, 2018
|
@aaronjudd good catch. Pretty sloppy of me not to remember that we use templates for the PDP as well. Fixed by permitting all users to subscribe to templates (previous functionality) but keeping the role check in the update method. |
pmn4
reviewed
Jan 29, 2018
| return Templates.update({ | ||
| _id: templateId, | ||
| type: "email" | ||
| type: "email", | ||
| shopId: shopId // Ensure that the template we're attempting to update is owned by the active shop. |
|
lgtm |
jshimko
approved these changes
Feb 6, 2018
|
As a shop admin I am able to execute the method for templates that are not mine but the method uses the active shop ID so I am prevented from actually doing anything harmful. |
brent-hoover
approved these changes
Feb 7, 2018
spencern
dismissed
aaronjudd’s stale review
Approved by @zenweasel and @jshimko
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds permission checks to the
template/email/updateserver method.I've tested and verified that as an admin you can still view and modify email templates.
I've also tested and verified that users without the
reaction-templatesrole for the primary shop cannot view or subscribe to the templates, and cannot modify them.We currently do not use shop specific templates, the default marketplace install of Reaction disables template editing for shops and uses the primary shop's templates for all emails. I've added this code to be compatible with marketplace shops, but it's not enabled right now anyway, and there's not a great way to test that.
To test:
reaction-templatesrole you can still view and modify templates.template/email/updatemethod from the client console. Verify that you are not able to do so successfully.