(chore) #1364 rename Import to Importer #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of a reserved keyword.
…of a reserved keyword.
…tps://github.com/reactioncommerce/reaction into refactor-1364-willopez-rename-import-to-importer
|
lgtm |
|
Once this PR is merged, please update https://docs.reactioncommerce.com/reaction-docs/master/reaction-import in the docs with this ticket: reactioncommerce/reaction-docs#491 |
…of a reserved keyword.
…tps://github.com/reactioncommerce/reaction into refactor-1364-willopez-rename-import-to-importer
kieckhafer
previously approved these changes
Feb 22, 2018
There was a problem hiding this comment.
Looks good.
Seeing this warning inside the tests, but all tests pass and this is not specific to this PR:
W20180222-10:42:59.216(-8)? (STDERR) (node:40145) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 152): Error: Method 'reaction/getUserId' not found [404]
aaronjudd
changed the title
aaronjudd
changed the title
|
@willopez I think the tests broke when I merged 1.8.2 in to this branch to get it ready to release. Let's pair on it tomorrow am and get it ready for 1.9 |
|
@spencern sure, just ping me. |
spencern
approved these changes
Mar 2, 2018
| @@ -330,7 +330,7 @@ export const methods = { | |||
| Meteor.call("orders/shipmentDelivered", order); | |||
| } | |||
|
|
|||
| // A batch update might be better option. Unfortunately Reaction.import doesn't support | |||
| // A batch update might be better option. Unfortunately Reaction.importer doesn't support | |||
There was a problem hiding this comment.
This should be capitalized Reaction.Importer as Reaction.importer doesn't exist.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1364
Impact: breaking
Type: refactor
Issue
Rename Import module to Importer. This prevents the usage of a reserved keyword.
Solution
server/api/core/import.jstoserver/api/core/importer.jsTesting
core/layout, core/taxes,included/shipping-shippo, included/taxes-taxcloud, core/core(settings), core/temaplates.js, server/startup/load-data.js,