Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename Import methods #1364

Closed
aaronjudd opened this issue Sep 9, 2016 · 3 comments
Closed

rename Import methods #1364

aaronjudd opened this issue Sep 9, 2016 · 3 comments
Assignees
@willopez
Milestone
Release 1.9

Comments

@aaronjudd
Copy link
Contributor

aaronjudd commented Sep 9, 2016 •
edited by kieckhafer
Loading

Rename import to a non reserved keyword for code clarity.

import { Import } from "/server/api/core/import";

Maybe just Importer would be sufficient?
@aaronjudd aaronjudd added this to the v0.18.0 milestone Sep 9, 2016
This was referenced Sep 9, 2016
Merged
Closed
@hrath2015
Copy link
Collaborator

May be it can be renamed as DataLoader or RCDataLoader

@aaronjudd aaronjudd added core and removed discussion labels Sep 9, 2016
@aaronjudd aaronjudd modified the milestones: v0.18.0, v0.20.0 Oct 19, 2016
@kieckhafer kieckhafer added ready and removed backlog labels Feb 15, 2017
@kieckhafer kieckhafer modified the milestones: Next, v0.20.0 Feb 15, 2017
@aaronjudd aaronjudd removed this from the Next milestone Apr 26, 2017
@willopez willopez self-assigned this Jan 29, 2018
@willopez
Copy link
Member

Importer sounds good to me.

@spencern
Copy link
Contributor

@willopez has a good start on this ticket but backed off to work on bugs last week.

@spencern spencern added this to the Release 1.9 milestone Feb 20, 2018
@willopez willopez mentioned this issue Feb 21, 2018
Merged
spencern added a commit that referenced this issue Mar 5, 2018
@spencern
Merge pull request #3613 from reactioncommerce/refactor-1364-willopez…
a47a1ba 
…-rename-import-to-importer

(chore) #1364 rename Import to Importer
@spencern spencern closed this as completed Mar 5, 2018
@spencern spencern mentioned this issue Mar 8, 2018
Merged
@snyk-bot snyk-bot mentioned this issue Jan 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willopez willopez

Labels
None yet
Projects
None yet
Milestone
Release 1.9
Development

No branches or pull requests
6 participants
@brent-hoover @aaronjudd @willopez @spencern @kieckhafer @hrath2015