Performance/Refactor remove revision control

[mikemurray]

Resolves #4237
Impact: breaking
Type: performance/refactor

Issue

Remove the Revision control system in favor of the Catalog as having both is redundant.

Solution

Remove all code, hooks, collections, and packages related to revision control.

Breaking changes

• The revision control system is removed, any custom packages that depend on it will no longer work.
• removed applyProductRevision from lib/api/products.js
• Cannot undo changes when editing a product
• PDP page will have an instant reflection of changes. Product grid will only see changes upon publishing.

Testing

1. As an admin
2. Add products, see that the changes show up immediately on PDP for customer and admin
3. Check the product grid has no changes for the customer, but immediate change for admin
4. Publish product, see product grid change for customers
5. Add products to cart and checkout
6. Fulfill orders and verify that inventory updates on the product via the PDP admin tools

[spencern]

@aldeed I think we should probably merge this into Release 2.0 and not into 1.12.0

[aldeed]

@mikemurray Nice work. I found a few things that seem like they should be removed.

• In /imports/plugins/core/catalog/client/containers/publishContainer.js, calls Meteor.call("revisions/discard"
• /imports/plugins/core/catalog/client/components/publishControls.js still has renderUndoButton method but it isn't called.
• In /imports/plugins/core/ui/client/components/media/mediaItem.js, there are some revision checks that should not be needed now
• In the json files in /private/data/i18n, there is a revisions object. It seems like most of these are not needed anymore. Maybe keep only unpublishedChanges and publishChanges?
• Should be safe to remove the Revisions line from /imports/collections/defineCollections.js

Still testing a few more things, but I'll start with those for my comments.

Fixed outlines issues

[mikemurray]

@aldeed Fixed your current set of issues. Let me know if you find any more.

[aldeed]

@mikemurray This is looking good to me. The only thing I noticed was that all the indicators for unpublished changes are gone. Is there no way to keep those? For example, by diffing Products w/ Catalog? I know the schemas are different so it's not necessarily easy.

[mikemurray]

@aldeed We would need to diff or otherwise know that there have been changes since the last publish.

[spencern]

Issue that was created to flag a product which has unpublished changes: #4264