Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Remove Shopify plugin #4395

Merged
merged 10 commits into from
Jul 19, 2018

Conversation

brent-hoover
Copy link
Collaborator

@brent-hoover brent-hoover commented Jul 3, 2018

Resolves #4308 (partially)
Impact: breaking
Type: refactor

Issue

This plugin is included by default even though the vast majority of people will not be using it

Solution

Move this plugin to the "community" namespace.

Breaking changes

To continue to use this plugin after this change you will need to:

  1. Clone this repo into <reaction root>/imports/plugins/custom/
  2. No additional changes should be required

Testing

App works w/o plugin

  1. rm -rf node_modules
  2. meteor npm install
  3. Start app
  4. Ensure everything works as normal

Community app works

  1. reaction reset -y
  2. Start app and ensure Shopify connector is not available
  3. Follow instructions in the README for installing (slightly different than others)
  4. Ensure Shopify plugin works as before

@brent-hoover brent-hoover changed the title [WIP] (refactor) Remove Shopify plugin files/edit package.json [WIP] (refactor) Remove Shopify plugin Jul 3, 2018
@brent-hoover brent-hoover changed the title [WIP] (refactor) Remove Shopify plugin (refactor) Remove Shopify plugin Jul 13, 2018
@brent-hoover
Copy link
Collaborator Author

@Akarshit assigning this to you since you recently worked with this plugin so hopefully you can test

@Akarshit
Copy link
Contributor

Akarshit commented Jul 14, 2018

@zenweasel I am getting Error: Cannot find module '/server/api' when I try to run the plugin with v.1.14 which is because Reaction should be imported in a different(1.14 compatible) way here
So I am not sure if I should approve this and open a issue in that repo.
But the current plugin is not compatible with 1.14.

@brent-hoover
Copy link
Collaborator Author

@Akarshit Updated

Copy link
Contributor

@Akarshit Akarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zenweasel Can you please look at the conflict.

@brent-hoover
Copy link
Collaborator Author

@Akarshit Conflicts merged

@brent-hoover brent-hoover dismissed Akarshit’s stale review July 17, 2018 21:14

Conflicts resolved

@brent-hoover
Copy link
Collaborator Author

@Akarshit Can you give this a thumbs up if ok ASAP?

@brent-hoover
Copy link
Collaborator Author

@Akarshit Conflicts resolved here again. Removing the shopify-api-node package removes a ton of dependent packages (only a few direct dependencies, but each of those dependencies had a ton of dependencies). I just regenerated the package-lock.json again using meteor npm install.

@spencern spencern merged commit 30f081c into release-1.14.0 Jul 19, 2018
@spencern spencern deleted the refactor-brent-remove-shopify-connector branch July 19, 2018 04:04
@spencern spencern mentioned this pull request Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants