-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) Remove Shopify plugin #4395
(refactor) Remove Shopify plugin #4395
Conversation
@Akarshit assigning this to you since you recently worked with this plugin so hopefully you can test |
@zenweasel I am getting |
@Akarshit Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zenweasel Can you please look at the conflict.
@Akarshit Conflicts merged |
@Akarshit Can you give this a thumbs up if ok ASAP? |
@Akarshit Conflicts resolved here again. Removing the |
Resolves #4308 (partially)
Impact: breaking
Type: refactor
Issue
This plugin is included by default even though the vast majority of people will not be using it
Solution
Move this plugin to the "community" namespace.
Breaking changes
To continue to use this plugin after this change you will need to:
<reaction root>/imports/plugins/custom/
Testing
App works w/o plugin
rm -rf node_modules
meteor npm install
Community app works
reaction reset -y