Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Product prices showing as $NaN.undefined on the customer product grid #4518

Merged
merged 9 commits into from
Aug 8, 2018

Conversation

kieckhafer
Copy link
Member

Resolves #4467
Impact: minor
Type: bugfix

Closing #4484 in favor of this PR.

Issue

When a Product is made visible and published without any Variant, Catalog customer gets price range as $NaN.undefined - $-NaN.undefined

Solution

Add a check in the product catalog publication that makes sure a product has visible variants on it before allowing it to be published to the Catalog.

Testing

  • Start the app
  • Login as an admin
  • Create a product, and make the top level product visible, but DO NOT make the variant visible
  • As an admin, see this product is visible to you on the grid (necessary for editing purposes)
  • Log out, and see as a customer, this product is not visible to you

@kieckhafer kieckhafer self-assigned this Aug 7, 2018
@kieckhafer kieckhafer requested a review from aldeed August 7, 2018 20:51
aldeed
aldeed previously requested changes Aug 7, 2018
Copy link
Contributor

@aldeed aldeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kieckhafer Looks good. There are some failing tests, probably just need to update the test data / factory to be valid products. Also, if you're not intentionally updating package-lock, you should remove it. I think those are just the changes that it automatically makes back and forth depending on where npm install is being run.

@kieckhafer kieckhafer dismissed aldeed’s stale review August 8, 2018 00:33

@aldeed ready for another look

@aldeed aldeed merged commit 4cb3be3 into release-1.15.0 Aug 8, 2018
@aldeed aldeed deleted the fix-4467-kieckhafer-undefindedPrice branch August 8, 2018 12:21
@spencern spencern mentioned this pull request Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants