Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update React 16.8.6 #5204

Merged
merged 9 commits into from
Jun 28, 2019
Merged

Conversation

mikemurray
Copy link
Member

Resolves: #5165
Impact: minor
Type: chore

Issue

React is out of date 16.4.2. This means we're missing out on hooks support as well as many other improvements over the last year.

Solution

Update react and react-dom to 16.8.6.

Breaking changes

Should be none.

Testing

  1. Run the app and make sure things work

@mikemurray mikemurray changed the title chore: Update React 16.8.6 [WIP] chore: Update React 16.8.6 Jun 6, 2019
@mikemurray mikemurray changed the title [WIP] chore: Update React 16.8.6 chore: Update React 16.8.6 Jun 27, 2019
@mikemurray mikemurray changed the title chore: Update React 16.8.6 [WIP] chore: Update React 16.8.6 Jun 27, 2019
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray mikemurray changed the title [WIP] chore: Update React 16.8.6 chore: Update React 16.8.6 Jun 27, 2019
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Everything seems to work as expected.

@kieckhafer kieckhafer merged commit e1cb22e into develop Jun 28, 2019
@kieckhafer kieckhafer deleted the feat-5165-mikemurray-react-16.8 branch June 28, 2019 02:19
@jeffcorpuz jeffcorpuz mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants