bug: Fix page title from not found #5245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
von-steinkirch
changed the title
Signed-off-by: Mia Steinkirch <mia.steinkirch@gmail.com>
von-steinkirch
force-pushed
the
bug-bt3gl-Fix_page_title_from_not_found
branch
from
dce4f04
to
8eedf28
Compare
|
FYI: @bt3gl there are lint errors on this PR: https://circleci.com/gh/reactioncommerce/reaction/46370?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link |
Signed-off-by: Mia Steinkirch <mia.steinkirch@gmail.com>
von-steinkirch
force-pushed
the
bug-bt3gl-Fix_page_title_from_not_found
branch
from
947c229
to
12ed953
Compare
added 2 commits
June 27, 2019 20:54
Signed-off-by: Mia Steinkirch <mia.steinkirch@gmail.com>
Signed-off-by: Mia Steinkirch <mia.steinkirch@gmail.com>
brent-hoover
approved these changes
Jun 28, 2019
imports/plugins/core/dashboard/client/components/OperatorLanding.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
|
@bt3gl In the future if @manueldelreal is tagged on a PR let's wait for his approval before merging. We don't want to merge in PR's that haven't passed QA. |
|
@zenweasel, sounds good and will do. In this specific case, I merged after chatting with @willopez. |
Merged
|
@bt3gl Yeah, regardless. No one has the authority to bypass QA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5041
Impact: minor
Type: bugfix
Issue
Title in admin pages was saying "Not-found" every tab.
Solution
Pairing with @mikemurray, this solution had two main steps:
Breaking changes
None.
Testing