-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix all react/no-deprecated
and react/prop-type
eslint warnings
#5307
chore: fix all react/no-deprecated
and react/prop-type
eslint warnings
#5307
Conversation
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@machikoyasuda not sure what the deal is with the DCO issue - it involves Maria's commits that aren't even in this branch. I've filed a ticket with them to see if they know what's going on: dcoapp/app#115 |
@kieckhafer You have 2 commits incorrectly signed off. To fix, head to your local branch and run:
Now your commits will have your sign off. Next run
|
@machikoyasuda but those aren't my commits, and they aren't in this branch at all. They are commits from Maria... somewhere in the app. |
…sling-reactNoDeprecated
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Fixed... somehow. It just went away when I made a new commit. Doesn’t make any sense to me, hopefully the ticket I made in that repo can provide some answers. |
Resolves #5247 & #5271
Impact: minor
Type: chore
Issue
We currently have many
react/no-deprecated
andreact/prop-type
eslint warnings.Solution
Fix (or disable) these warnings, and then update our
eslint
rules to makereact/no-deprecated
andreact/prop-type
anerror
so new violations are not introduced.I have update the components to use the
UNSAFE_
version fo deprecated react life cycle methods, as these components will be updated to be functional components in the future.Updated rules: reactioncommerce/reaction-eslint-config#15
Breaking changes
None.
Testing
react/no-deprecated
andreact/prop-type
warnings (and no errors)