Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix all react/no-deprecated and react/prop-type eslint warnings #5307

Merged
merged 5 commits into from
Jul 13, 2019

Conversation

kieckhafer
Copy link
Member

Resolves #5247 & #5271
Impact: minor
Type: chore

Issue

We currently have many react/no-deprecated and react/prop-type eslint warnings.

Solution

Fix (or disable) these warnings, and then update our eslint rules to make react/no-deprecated and react/prop-type an error so new violations are not introduced.

I have update the components to use the UNSAFE_ version fo deprecated react life cycle methods, as these components will be updated to be functional components in the future.

Updated rules: reactioncommerce/reaction-eslint-config#15

Breaking changes

None.

Testing

  1. run eslint
  2. see there are no longer any react/no-deprecated and react/prop-type warnings (and no errors)

Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@kieckhafer kieckhafer added this to In progress in eslint audit via automation Jul 11, 2019
@kieckhafer kieckhafer moved this from In progress to Review in progress in eslint audit Jul 11, 2019
@kieckhafer kieckhafer changed the base branch from master to develop July 11, 2019 18:38
@kieckhafer
Copy link
Member Author

kieckhafer commented Jul 12, 2019

@machikoyasuda not sure what the deal is with the DCO issue - it involves Maria's commits that aren't even in this branch. I've filed a ticket with them to see if they know what's going on: dcoapp/app#115

eslint audit automation moved this from Review in progress to Reviewer approved Jul 13, 2019
@machikoyasuda
Copy link
Contributor

@kieckhafer You have 2 commits incorrectly signed off. To fix, head to your local branch and run:

git rebase HEAD~72 --signoff

Now your commits will have your sign off. Next run

git push --force-with-lease origin chore-kieckhafer-esling-reactNoDeprecated

@kieckhafer
Copy link
Member Author

kieckhafer commented Jul 13, 2019

@machikoyasuda but those aren't my commits, and they aren't in this branch at all. They are commits from Maria... somewhere in the app.

@kieckhafer
Copy link
Member Author

kieckhafer commented Jul 13, 2019

Fixed... somehow. It just went away when I made a new commit. Doesn’t make any sense to me, hopefully the ticket I made in that repo can provide some answers.

@kieckhafer kieckhafer merged commit ccb3738 into develop Jul 13, 2019
eslint audit automation moved this from Reviewer approved to Done Jul 13, 2019
@kieckhafer kieckhafer deleted the chore-kieckhafer-esling-reactNoDeprecated branch July 13, 2019 02:53
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
eslint audit
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants