Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: manage product tags in bulk #5485

Merged
merged 24 commits into from
Sep 10, 2019
Merged

Conversation

willopez
Copy link
Member

@willopez willopez commented Aug 28, 2019

Resolves #5453
Impact: Major
Type: feature

Summary

This PR adds functionality to manage product tags in bulk. A user will be able to add or remove a set of tags to/from a set of products.

This feature includes using the new Select component from the Catalyst UI, this required updating react-select to v3.0.4

Testing

  1. Select 1 or more products on the products page
  2. Click the actions menu and select Add/Remove tags
  3. Select 1 or more tags
  4. Select on the action from the action button, either Add tags to product(s) or Remove tags from product(s)
  5. Click the button to execute the action

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez self-assigned this Sep 5, 2019
@rymorgan
Copy link
Contributor

rymorgan commented Sep 5, 2019

  • Shadow, elevation on the quick add card is wrong. I think this is fixed already but maybe you don’t have the changes pulled into your branch? Just double-checking.

  • Missing translation on card.
    Screen Shot 2019-09-05 at 3 29 58 PM

  • There should be space between the two inline alerts alerts. @cassytaylor how much space?
    Screen Shot 2019-09-05 at 3 04 06 PM

@cassytaylor
Copy link

cassytaylor commented Sep 5, 2019

• +1 for the shadows being incorrect - it looks like both the product table card and quick action card use shadows that are too big. I'm really sorry I still don't have great documentation for elevation yet, but our cards use "Shadow02" documented here - zpl.io/bJWYAP9

  • The "Create product" button should hide when any Quick Action card is open. Currently it's still shown when the "Filter products by file" card is open.

• Agreed on messaging needing rewriting... I'm not a great UX copywriter 😬

  • Agreed on the disabled state is confusing.

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez marked this pull request as ready for review September 5, 2019 23:52
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on syntax and style.

},
helpText: {
marginLeft: "20px",
letterSpacing: "0.28px",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use literal numbers, and omit units from letter spacing and margin.

This comment was marked as resolved.

@mikemurray
Copy link
Member

@willopez If I dismiss the alert, I can't get it to reappear again even though I still have no selected tags.

image

@rymorgan
Copy link
Contributor

rymorgan commented Sep 9, 2019

These updates related to - #5525

Copy updates for inline alerts.
Screen Shot 2019-09-09 at 11 00 22 AM

Updated copy -
16 products found from the imported file.

3-products-tagged

Updated copy -
Aviator added to 3 products.

In the case where you have two tags it should look like this -
Aviator added to 3 products.
Socks added to 3 products.

13-productds

Updated copy -
13 products were already tagged with the provided tags. No change made.

In the case where you have mixed results, it can look like this -
Aviator added to 3 products.
7 products were already tagged with the provided tags. No change made.

Screen Shot 2019-09-09 at 11 46 56 AM

Updated copy -
Please select one or more tags.

@rymorgan
Copy link
Contributor

rymorgan commented Sep 9, 2019

Spacing and alignment of the quick edit card are off.
Screen Shot 2019-09-09 at 11 52 19 AM

The right alignment of 'X' end of the select, and split button should all right align.
The bottom marge of the card should have more space looks like space(1) when it should be space(3).

For reference -
https://zpl.io/aRGzZNz

Screen Shot 2019-09-09 at 11 56 33 AM

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
Copy link
Member Author

willopez commented Sep 9, 2019

@rymorgan I have implemented the copy changes. Ready for your review.

},
helpText: {
marginLeft: "20px",
letterSpacing: "0.28px",

This comment was marked as resolved.

@rymorgan
Copy link
Contributor

rymorgan commented Sep 9, 2019

Screen Shot 2019-09-09 at 3 21 59 PM

Should read -
var tag added to 3 products.

  • tag should be bolded not in quotes.
  • Product should be the plural, products

Screen Shot 2019-09-09 at 3 24 40 PM

  • Instead of "No update performed" it should say "No change made."

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
Copy link
Member Author

willopez commented Sep 9, 2019

@rymorgan I have implemented you changes. Except for making tag bold, as it's no currently possible due to the fact that the messages are translated strings.

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
Copy link
Member Author

@manueldelreal Can you please test this PR with our sample data set and SDI's data set. Thanks!

@rymorgan
Copy link
Contributor

@willopez I've reviewed and it's good to go from my perspective.

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
…feat-bulkactions-ui-updates

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez merged commit 7ad816f into develop Sep 10, 2019
@willopez willopez deleted the feat-bulkactions-ui-updates branch September 10, 2019 21:36
@kieckhafer kieckhafer mentioned this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants