-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: manage product tags in bulk #5485
Conversation
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
…feat-bulkactions-ui-updates
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
…feat-bulkactions-ui-updates
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
…feat-bulkactions-ui-updates
…feat-bulkactions-ui-updates
…feat-bulkactions-ui-updates
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
…feat-bulkactions-ui-updates
|
• +1 for the shadows being incorrect - it looks like both the product table card and quick action card use shadows that are too big. I'm really sorry I still don't have great documentation for elevation yet, but our cards use "Shadow02" documented here - zpl.io/bJWYAP9
• Agreed on messaging needing rewriting... I'm not a great UX copywriter 😬
|
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on syntax and style.
imports/plugins/included/product-admin/client/components/FilterByFileCard.js
Outdated
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/TagSelector/TagSelector.js
Outdated
Show resolved
Hide resolved
}, | ||
helpText: { | ||
marginLeft: "20px", | ||
letterSpacing: "0.28px", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use literal numbers, and omit units from letter spacing and margin.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
imports/plugins/included/product-admin/client/components/ProductTable.js
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/TagSelector/Notifications.js
Show resolved
Hide resolved
@willopez If I dismiss the alert, I can't get it to reappear again even though I still have no selected tags. |
These updates related to - #5525 Copy updates for inline alerts. Updated copy - Updated copy - In the case where you have two tags it should look like this - Updated copy - In the case where you have mixed results, it can look like this - Updated copy - |
Spacing and alignment of the quick edit card are off. The right alignment of 'X' end of the select, and split button should all right align. For reference - |
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@rymorgan I have implemented the copy changes. Ready for your review. |
imports/plugins/included/product-admin/client/components/FilterByFileCard.js
Outdated
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/TagSelector/TagSelector.js
Outdated
Show resolved
Hide resolved
}, | ||
helpText: { | ||
marginLeft: "20px", | ||
letterSpacing: "0.28px", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@rymorgan I have implemented you changes. Except for making tag bold, as it's no currently possible due to the fact that the messages are translated strings. |
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@manueldelreal Can you please test this PR with our sample data set and SDI's data set. Thanks! |
@willopez I've reviewed and it's good to go from my perspective. |
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
…feat-bulkactions-ui-updates Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Resolves #5453
Impact: Major
Type: feature
Summary
This PR adds functionality to manage product tags in bulk. A user will be able to add or remove a set of tags to/from a set of products.
This feature includes using the new Select component from the Catalyst UI, this required updating
react-select
tov3.0.4
Testing
Add/Remove tags