refactor(card): use CardHeader with Catalyst defaults for Product Table #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le; use Catalyst Typography for Quick Edit card helptext Signed-off-by: Machiko Yasuda <machiko@reactioncommerce.com>
Signed-off-by: Machiko Yasuda <machiko@reactioncommerce.com>
Truway33
approved these changes
Sep 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Machiko Yasuda machiko@reactioncommerce.com
Resolves #issueNumber
Impact: minor
Type: bugfix|refactor
Issue
The Product Table uses a Material-UI Card, and the top padding is off. The Card's CardHeader's secondaryText font color is also off. These will be addressed in an upcoming Catalyst release, and when reactioncommerce/catalyst#94 is released, this ticket can also be tested and merged.
Solution
Breaking changes
none
Testing
More detail for what each of these sections should include are available in our Contributing Docs