Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Tags from server/no-meteor to node-app #5665

Merged
merged 4 commits into from
Oct 3, 2019

Conversation

kieckhafer
Copy link
Member

Resolves #5624
Impact: minor
Type: refactor

As part of our effort to separate our Reaction Admin from our Reaction Node API, we are moving our GraphQL services from their respective /imports/plugins/*/server/no-meteor/ folders into their new /node-app/{core-services|plugins}/* folder.

Updates also include future-proofing some existing code, including adding filetype extensions (and index.js to imports)

Breaking changes

Any custom plugins that import files directly from the Tags package will need to be updated.

Testing

  1. Start the application and see that it works as it should.
  2. See that you can add / remove tags from products, create tags, etc

Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@kieckhafer kieckhafer changed the title [WIP] refactor: move Tags from server/no-meteor to node-app refactor: move Tags from server/no-meteor to node-app Oct 3, 2019
@kieckhafer kieckhafer requested a review from aldeed October 3, 2019 21:11
@aldeed aldeed merged commit 8382aca into develop Oct 3, 2019
@aldeed aldeed deleted the refactor-kieckhafer-movePackageToNodeApp-tags branch October 3, 2019 22:08
@willopez willopez mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants