refactor: pass cart down to calculateOrderTaxes fn #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5583
Impact: minor
Type: refactor
Changes
When calling
calculateOrderTaxesfunction for a fulfillment group that's in a cart, the parentcartobject is passed in now. When called for an order, it'snull. This is helpful for some tax plugins that may be storing additional information on the cart itself.Breaking changes
None
Testing
Using logging or Node debugger, verify that
cartis set on thecalculateOrderTaxesfunction input object. It is called whenever you add or remove items from your cart or otherwise modify it.