Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems with accounts queries #6060

Merged
merged 8 commits into from Jan 29, 2020
Merged

Fix problems with accounts queries #6060

merged 8 commits into from Jan 29, 2020

Commits on Jan 28, 2020

  1. refactor: make authContext param optional in hasPermission 

    Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
    @aldeed
    aldeed committed Jan 28, 2020
    Copy the full SHA
    fd34f20 View commit details
    Browse the repository at this point in the history

  2. feat: update accounts query to return all accounts 

    Filtering by shop ID is no longer possible because
accounts do not belong to any one shop.

Filtering by one or more account groups is now possible.

All accounts are returned, and not just non-admins.

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
    @aldeed
    aldeed committed Jan 28, 2020
    Copy the full SHA
    c2d1251 View commit details
    Browse the repository at this point in the history

  3. fix: return Account.groups when requested in GQL 

    fixes #5906

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
    @aldeed
    aldeed committed Jan 28, 2020
    Copy the full SHA
    58efcc7 View commit details
    Browse the repository at this point in the history

  4. fix: do not rely on account.shopId anywhere 

    It's optional, we no longer set it, and
it doesn't mean anything

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
    @aldeed
    aldeed committed Jan 28, 2020
    Copy the full SHA
    218a734 View commit details
    Browse the repository at this point in the history

  5. test: fix test failures 

    Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
    @aldeed
    aldeed committed Jan 28, 2020
    Copy the full SHA
    81f9aff View commit details
    Browse the repository at this point in the history

  6. test: fix tests 

    Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
    @aldeed
    aldeed committed Jan 28, 2020
    Copy the full SHA
    9a368ea View commit details
    Browse the repository at this point in the history

  7. chore: rename .eslintrc file 

    to silent ES module warning

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
    @aldeed
    aldeed committed Jan 28, 2020
    Copy the full SHA
    7238cda View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. refactor: rename query to plural, and fix map 

    Signed-off-by: Erik Kieckhafer <ek@ato.la>
    @kieckhafer
    kieckhafer committed Jan 29, 2020
    Copy the full SHA
    240649f View commit details
    Browse the repository at this point in the history