Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: newly duplicated promotion should have created state #6742

Merged
merged 5 commits into from
Jan 6, 2023
Merged

fix: newly duplicated promotion should have created state #6742

merged 5 commits into from
Jan 6, 2023

Conversation

vannguyenn
Copy link
Contributor

Duplicated promotion should have created state
Related PR: reactioncommerce/kinetic#152

@vannguyenn
fix: newly duplicated promotion should have created state
3606eed 
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023 •
edited

⚠️ No Changeset found

Latest commit: eb76d6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vannguyenn
Copy link
Contributor Author

Failed at installing pnpm dependencies, seems not related to my change https://app.circleci.com/pipelines/github/reactioncommerce/reaction/6267/workflows/0f7d84c3-4b27-4071-a18d-433d519c4cbb/jobs/77730

@vannguyenn
fix: failed build
2fb7397 
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vanpho93
vanpho93 reviewed Jan 6, 2023
View reviewed changes
Copy link
Member

@vanpho93 vanpho93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should revert changes related to @snyk

@vannguyenn
revert change of snyk
fa83eb3 
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@vannguyenn
fix: revert change to snyk
43d3981 
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@vannguyenn
fix: add state to update promotion input
eb76d6c 
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@brent-hoover brent-hoover merged commit b8b015a into feat/promotions Jan 6, 2023
@brent-hoover brent-hoover deleted the fix/duplicated-promotion-state branch January 6, 2023 18:31
vanpho93 pushed a commit that referenced this pull request Apr 24, 2023
@brent-hoover @vanpho93
Merge pull request #6742 from reactioncommerce/fix/duplicated-promoti…
0251429 
…on-state

fix: newly duplicated promotion should have created state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brent-hoover brent-hoover brent-hoover approved these changes

@vanpho93 vanpho93 vanpho93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vannguyenn @brent-hoover @vanpho93