fix infinite loop in new datetime converter, fixes issue #463 #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fixes #463
What is the current behavior? (You can also link to an open issue here)
The problem was that, as the default ResolveContract() calls CreateContact(), in your CreateContact() you can't call ResolveContract() on the embedded contractResolver, as it will also (often) inherit from DefaultContractResolver.
So it loops.
What is the new behavior (if this is a feature change)?
I moved the code in ResolveContract instead, which make the issue disappear. It won't loop anymore!
I also check if the contract is already overriden by the other resolver. In this case let it handle the conversion.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information: