.NET7.0+ AOT supported #1710
Merged
.NET7.0+ AOT supported #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
- Coverage 87.73% 86.62% -1.11%
==========================================
Files 33 34 +1
Lines 2348 2064 -284
Branches 294 296 +2
==========================================
- Hits 2060 1788 -272
+ Misses 208 199 -9
+ Partials 80 77 -3 ☔ View full report in Codecov by Sentry. |
ChrisPulman
approved these changes
Jun 9, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is an implementation complement to #1389, which enables
Generated.gcodes to be preserved during trimming, thereby supporting AOT publish of .NET 7.0 or later versions.This implementation has been used in the WebApiClient project and is valid for .NET versions 5.0 to 9.0 and is safe.What is the current behavior?
<TrimMode>full</TrimMode>is the default behavior of .NET8. Once<PublishAot>true</PublishAot>is turned on, all the code currently generated inGenerated.gwill be trimmed, causing AOT publishing to fail.What is the new behavior?
Cleverly use ModuleInitializerAttribute in combination with DynamicDependencyAttribute to prevent the code of
Generated.gfrom being trimmed.What might this PR break?
This PR is non-destructive, but requires the target project to be .NET 5 or above to take effect.
Please check if the PR fulfills these requirements
Other information: